More exhaustive assertions for native rule tag propagation tests #25050
+63
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
src/test/shell/bazel/tags_propagation_native_test.sh
assert_contains_n "Command Line:" n output1
ExecutionInfo: {
is inappropriate asTemplateExpand
also have execution info.assert_contains_n "(local|no-cache|no-remote):" n output1
Counting
n
increases confidence that all expected actions have the execution info they should have. e.g. tags propagated for tests, but not other actions when--incompatible_allow_tags_propagation=false
--experimental_allow_tags_propagation
->--incompatible_allow_tags_propagation
Addresses warnings in test logs.
Changes in
src/test/shell/unittest.bash
address a bug inassert_contains_n
which on failure was using the wrong argument to refer to the input file. For consistency other places were also updated to use$file
instead of the argument number.