Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More exhaustive assertions for native rule tag propagation tests #25050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Silic0nS0ldier
Copy link
Contributor

In src/test/shell/bazel/tags_propagation_native_test.sh

  • assert_contains_n "Command Line:" n output1
    ExecutionInfo: { is inappropriate as TemplateExpand also have execution info.
  • assert_contains_n "(local|no-cache|no-remote):" n output1
    Counting n increases confidence that all expected actions have the execution info they should have. e.g. tags propagated for tests, but not other actions when --incompatible_allow_tags_propagation=false
  • --experimental_allow_tags_propagation -> --incompatible_allow_tags_propagation
    Addresses warnings in test logs.

Changes in src/test/shell/unittest.bash address a bug in assert_contains_n which on failure was using the wrong argument to refer to the input file. For consistency other places were also updated to use $file instead of the argument number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant