Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset read offset when download blob failed #25052

Closed

Conversation

Kila2
Copy link

@Kila2 Kila2 commented Jan 24, 2025

Reset the read offset when downloading a blob fails to address the issue of some remote cache servers not supporting slice downloads.

@Kila2 Kila2 requested a review from a team as a code owner January 24, 2025 09:25
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 24, 2025
@werkt
Copy link
Contributor

werkt commented Jan 24, 2025

This needs to be made into an option, and disabled by default. Without a progressive read, you are limited to the available bandwidth to server / concurrent downloads * remote_timeout. There is no reason to make this global.

Or you can do the nicer bit and recognize an InvalidArgument or some such return and then reset.

@Kila2
Copy link
Author

Kila2 commented Jan 26, 2025

Thank you for the suggestion. After reviewing, it seems challenging to implement this efficiently without introducing unnecessary complexity. Simply resetting CountingOutputStream is not ideal. If possible, we could consider retaining the read offset for DEADLINE_EXCEEDED status and resetting it for other statuses. For now, I’ll close this PR but appreciate your feedback and hope to revisit it with a better approach in the future.

@Kila2 Kila2 closed this Jan 26, 2025
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants