Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSTEAMA-1412: Add Reverb dependency as the transpiled version #12189

Open
wants to merge 67 commits into
base: latest
Choose a base branch
from
Open

WSTEAMA-1412: Add Reverb dependency as the transpiled version #12189

wants to merge 67 commits into from
+789 −44

Conversation

alex-magana
Copy link
Contributor

@alex-magana alex-magana commented Nov 18, 2024 •
edited
Loading

Resolves JIRA [WSTEAMA-1412]

Overall changes

Integrate the hosted version of Reverb into the page for tracking purposes.

https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js

Code changes

  • Add the hosted version of Reverb to the page.
  • Use Reverb for page view events and component page/click events.
  • Enable service level migration from the current tracking logic.

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

karinathomasbbc and others added 17 commits October 23, 2024 12:38
@karinathomasbbc
Add reverb as a dependency
1af2a31
@karinathomasbbc
use git+ssh syntax
881309c
@karinathomasbbc
Following guidelines in https://github.com/bbc/delivery-engineering/t…
d8d342b 
…ree/main/docs/examples/codebuild/github-oauth
@karinathomasbbc
Following guidelines in https://github.com/bbc/delivery-engineering/t…
50f1608 
…ree/main/docs/examples/codebuild/github-oauth
@karinathomasbbc
TEMP: don't check package manager; remove winston as npm does not sup…
ecf0f23 
…port patching
@karinathomasbbc
Adding GITHUB_TOKEN to builds which install node modules
8cf70ff
@karinathomasbbc
Use git+ssh syntax
f4eb63c
@karinathomasbbc
Revert "TEMP: don't check package manager; remove winston as npm does…
d7c72fb 
… not support patching"

This reverts commit ecf0f23.
@karinathomasbbc
Use github instead of github+ssh syntax
5dcb396
@alex-magana
Update bbc/reverb reference
2fe6d28
@alex-magana
Change reference
edbba63
@alex-magana
Add flag
21134ea
@alex-magana
Revert flag
bdc6cba
@alex-magana
Change reverb reference
e54735f
@alex-magana
Remove Reverb from cache and lock file
a56a4f3
@alex-magana
Update Reverb reference to match Webcore
5617923
@alex-magana
Serve compiled Reverb code
a7cfef2
alex-magana and others added 29 commits December 16, 2024 19:51
@alex-magana
Merge branch 'latest' into reverb-dependency-minified
6f86298
@louisearchibald
adds producer name value for afaanoromoo
47cde59
@louisearchibald
correct name
109b613
@louisearchibald
adds producer name value for afrique amharic arabic archive and azeri
974f998
@louisearchibald
add producer name to config for bengali burmese cymrufyw gahuza gujar…
71b8703 
…ati and hausa
@louisearchibald
update config for hindi igbo indonesia japanese and korean
b3a2931
@louisearchibald
update kyrgyz marathi mundo naidheachdan & nepali
91e38e1
@louisearchibald
update config for news newsround pashto pidgin & portuguese
99570ed
@louisearchibald
update service config for punjabi russian scotland serbian & sinhala
721cc0c
@louisearchibald
update service config for somali sport swahili tamil & telugu
92addb7
@louisearchibald
update service config for thai tigrinya turkce ukchina & ukrainian
078e69f
@louisearchibald
update service config for urdu uzbek vietnamese ws yoruba & zhongwen
c18fb40
@alex-magana
Remove useReverb prop from ATIAnalytics component
a45c784
@alex-magana
Remove useReverb prop from the MostRead component
f0c28b2
@alex-magana
Remove useReverb prop from Top Stories component
3e46f44
@alex-magana
Remove useReverb prop from the FeaturesAnalysis component
5a008d4
@alex-magana
Merge branch 'latest' into reverb-dependency-minified
21122ae
@alex-magana
Merge pull request #12244 from bbc/WSTEAMA-1508-adds-producerName-to-…
1c68e74 
…service-config

WSTEAMA-1508 - Adds producer name to service config for all services
@alex-magana
Merge pull request #12253 from bbc/WSTEAMA-1496-enable-reverb-service…
d98957c 
…-level-migration

WSTEAMA-1496: Enable service level migration for Reverb
@alex-magana
Add producerName to config generation assertions
7e19f85
@alex-magana
Fix ATIAnalytics and EventTrackingContext ATI tests assertions
f68a76b
@alex-magana
Update PageLayoutWrapper copyright text
37f57da
@alex-magana
Add Reverb boilerplate to the CanonicalRenderer snapshot
547e8f7
@alex-magana
Add producer name to snapshot
f5ea110
@alex-magana
Merge branch 'latest' into reverb-dependency-minified
55035ad
@eagerterrier
Merge branch 'latest' into reverb-dependency-minified
28465d9
@alex-magana
Update snapshots to reflect 2025 in the page copyright
9e013d7
@alex-magana
Merge branch 'reverb-dependency-minified' of github.com:bbc/simorgh i…
78e8dfb 
…nto reverb-dependency-minified
@amoore108
WSTEAMA-1484 - Reverb unit tests (#12265)
4216516 
* WSTEAMA-1484 - Reverb unit tests

* Update index.test.ts

* add test to root component

* Add `ReverbClient` type

* Update eventTracking.ts

* Update eventTracking.ts

* Update index.test.ts

* Update index.test.ts

* sendBeacon test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alex-magana @karinathomasbbc @louisearchibald @eagerterrier @amoore108