Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1558: Watch Live Button UX & A11y #12263

Merged
merged 10 commits into from
Jan 10, 2025
Merged

WSTEAM1-1558: Watch Live Button UX & A11y #12263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
466a5d6
WSTEAM1-1558: Adds initial styles and Screen Reader UX
Isabella-Mitchell Jan 7, 2025
154427e
WSTEAM1-1558: Applies hover and forced colour styles
Isabella-Mitchell Jan 8, 2025
bc7dfbd
WSTEAM1-1558: Tidy
Isabella-Mitchell Jan 8, 2025
4066223
WSTEAM1-1558: Fix padding
Isabella-Mitchell Jan 8, 2025
60b2b91
Merge in origin
Isabella-Mitchell Jan 8, 2025
5cf2dce
WSTEAM1-1558: A11y updates
Isabella-Mitchell Jan 8, 2025
3f714a3
WSTEAM1-1558: A11y update
Isabella-Mitchell Jan 8, 2025
5d901a5
WSTEAM1-1558: UX updates
Isabella-Mitchell Jan 8, 2025
00bcad1
WSTEAM1-1558: Improves nested styles syntax
Isabella-Mitchell Jan 9, 2025
870c2b1
WSTEAM1-1558: adds translation
Isabella-Mitchell Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/app/components/LiveMediaStream/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ const LiveMediaStream = ({ mediaCollection }: Props) => {
className="hoverStylesText"
>
<Text size="pica" fontVariant="sansBold" as="span">
{short}
</Text>{' '}
<VisuallyHiddenText>, </VisuallyHiddenText>
{short},{' '}
</Text>
<Text size="pica" fontVariant="sansRegular" as="span">
{networkName}
<VisuallyHiddenText>, </VisuallyHiddenText>
</Text>
</Text>
{warnings && (
Expand All @@ -113,6 +113,7 @@ const LiveMediaStream = ({ mediaCollection }: Props) => {
css={styles.guidanceMessage}
>
{warnings.warning_text}
<VisuallyHiddenText>, </VisuallyHiddenText>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this as we have a full stop as part of the guidance message text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. do we know whether editorial always provide this as part of the guidance message?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it is a sentence, with proper grammer it should contain one at the end? Do we already have this string in our translations? Could check if so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is coming through in the data (rather than via translation) - have asked Shayne for more clarity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, yess this comes through the BFF and is provided by the editors who write the article.

</Text>
)}
<div
Expand Down
2 changes: 2 additions & 0 deletions src/app/components/icons/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ export const PlayIcon = ({ className }: { className?: string }) => (
width="12"
height="12"
className={className}
focusable="false"
aria-hidden="true"
>
<path d="M29 16 5.8 1v30z" />
</svg>
Expand Down
Loading