Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localise Other languages footer link #12268

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

jordit
Copy link
Contributor

@jordit jordit commented Jan 10, 2025

Resolves JIRA n/a

Overall changes

Localise the Other languages link pointing to https://www.bbc.com/ws/languages on the page footer of all WS languages except Gahuza

Code changes

  • Edited Other languages llink on the links section of the languages config ts files
  • Updated snapshots

Testing

  1. Open the front pages and the Other Languages item (linking to https://www.bbc.com/ws/languages) should now be localised and not appear in English.
footer_pt footer_ru footer_fa footer_zh

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

Copy link
Contributor

@amoore108 amoore108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jordit
Copy link
Contributor Author

jordit commented Jan 10, 2025

Thanks @Isabella-Mitchell and @amoore108

@jordit jordit merged commit bc4c43d into latest Jan 10, 2025
11 checks passed
@jordit jordit deleted the localise-other-languages-footer-link branch January 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants