-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1567: Change padding for large breakpoint AND Add 16px after Live label #12295
Merged
+302
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayneahchoon
changed the title
WSTEAM1-1567: Change padding for large breakpoint
WSTEAM1-1567: Change padding for large breakpoint AND Add 16px after Live label
Jan 17, 2025
…imorgh into WSTEAM1-1567-LIVE-LARGE-BREAKPOINT
karinathomasbbc
approved these changes
Jan 20, 2025
Louis-Matsika
approved these changes
Jan 22, 2025
Isabella-Mitchell
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Note I think a few of the images in the PR description are outdated since they don't show the padding between the live label and title. I can see the correct padding on storybook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1593
Resolves JIRA WSTEAM1-1567
Overall changes
Changes mark up and adds manual padding on live headers.
Screen.Recording.2025-01-16.at.16.30.09.mov
Header with Image and no Video
Header with no Image and no Video
Header with Image and Video
Header with no Image and Video
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines