Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1567: Change padding for large breakpoint AND Add 16px after Live label #12295

Merged
merged 17 commits into from
Jan 22, 2025

Conversation

shayneahchoon
Copy link
Contributor

@shayneahchoon shayneahchoon commented Jan 16, 2025

Resolves JIRA WSTEAM1-1593
Resolves JIRA WSTEAM1-1567

Overall changes

Changes mark up and adds manual padding on live headers.

Screen.Recording.2025-01-16.at.16.30.09.mov

Header with Image and no Video
Screenshot 2025-01-17 at 14 41 52

Header with no Image and no Video
Screenshot 2025-01-17 at 14 42 46

Header with Image and Video
Screenshot 2025-01-17 at 14 42 02

Header with no Image and Video
Screenshot 2025-01-17 at 14 42 19

Code changes

  • Adds manual padding on live page headers.

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@shayneahchoon shayneahchoon changed the title WSTEAM1-1567: Change padding for large breakpoint WSTEAM1-1567: Change padding for large breakpoint AND Add 16px after Live label Jan 17, 2025
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Note I think a few of the images in the PR description are outdated since they don't show the padding between the live label and title. I can see the correct padding on storybook.

@shayneahchoon shayneahchoon merged commit 97de1df into latest Jan 22, 2025
11 checks passed
@shayneahchoon shayneahchoon deleted the WSTEAM1-1567-LIVE-LARGE-BREAKPOINT branch January 22, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants