-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update argfiles for PRs for DB name and tails #1426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loneil
changed the title
Update argfiles for PRs for DB name and tails
[DON'T MERGE] Update argfiles for PRs for DB name and tails
Oct 30, 2024
Deployment URLs ready for review. |
loneil
force-pushed
the
chore/prValuesTweaks
branch
from
November 5, 2024 23:38
d403fa5
to
a0dd29d
Compare
loneil
force-pushed
the
chore/prValuesTweaks
branch
from
November 5, 2024 23:39
bdbe87a
to
e14effe
Compare
loneil
force-pushed
the
chore/prValuesTweaks
branch
from
November 6, 2024 00:37
84da779
to
a0dd29d
Compare
Signed-off-by: Lucas ONeil <[email protected]>
loneil
force-pushed
the
chore/prValuesTweaks
branch
from
November 6, 2024 00:38
ffb55e5
to
eb3a538
Compare
loneil
changed the title
[DON'T MERGE] Update argfiles for PRs for DB name and tails
Update argfiles for PRs for DB name and tails
Nov 6, 2024
esune
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting very confused about our dev/test/prod deployments having an 'askar-wallet' db and PRs having 'default' so lets make those match for OCP deployments. Can normalize the DB name now that the fix here is in: #1428 (thanks to Ivan for finding that out)
Also update to have PRs use dev tails server