do not merge - For testing: added workflows to delete images and deployment #924
Conversation
|
Resolves: #598 |
Signed-off-by: Rajpal Chauhan <[email protected]>
Signed-off-by: Rajpal Chauhan <[email protected]>
rajpalc7
had a problem deploying
to
development
GitHub Actions
Failure
rajpalc7
had a problem deploying
to
development
GitHub Actions
Failure
rajpalc7
had a problem deploying
to
development
GitHub Actions
Failure
|
Hi @esune , This is ready for testing now. Lets connect whenever you are available. |
Signed-off-by: Rajpal Chauhan <[email protected]>
Signed-off-by: Rajpal Chauhan <[email protected]>
rajpalc7
had a problem deploying
to
development
GitHub Actions
Failure
| push: | ||
| branches: | ||
| - ghcr-clean |
There was a problem hiding this comment.
Unsure about why there is a push trigger on the ghcr-clean branch: as noted previously, I don't think we want to trigger the action on push to any branch, but just run on a schedule and/or manually.
There was a problem hiding this comment.
Hi @esune i am testing workflow by running it on my local branch. Deleted the push trigger after successful testing.
.github/workflows/on_pr_closed.yaml
Outdated
| @@ -2,19 +2,20 @@ name: Uninstall PR instance | |||
| on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| - ghcr-clean | |||
There was a problem hiding this comment.
This is incorrect, PRs should be targeting main (as it was set to do before).
There was a problem hiding this comment.
Hi @esune i am testing workflow by running on my branch . Reverted back to main now.
plugins/test.yaml
Outdated
| @@ -0,0 +1 @@ | |||
| testS | |||
There was a problem hiding this comment.
I assume this is the test file used to trigger the deployment: it should not be part of the PR though.
There was a problem hiding this comment.
Hi @esune i am testing stuff to trigger the workflow. Deleted the test file now
Signed-off-by: Rajpal Chauhan <[email protected]>
Signed-off-by: Rajpal Chauhan <[email protected]>
Signed-off-by: Rajpal Chauhan <[email protected]>
Signed-off-by: Rajpal Chauhan <[email protected]>
Signed-off-by: Rajpal Chauhan <[email protected]>
|
Hi @esune, I was able to re-test all the 3 jobs successfully with suggested changes. I can demo it tomorrow and we can go there. |
rajpalc7
changed the title
do not merge - For testing creating github action job to delete images older than 30 days every tuesday, closing PR jobs and stale issues.