Add support toggling json view of schemas in CreateSchemaForm #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
|
Just adding to note to hold any merging until after Emiliano cuts the next release for Traction to go to Test and Prod. |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Deployment URLs ready for review. |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Gavinok
force-pushed
the
toggle-json-for-schema
branch
from
16d633c to
dd67b25
Compare
|
This is a really good feature. We should have others tickets to do this for other objects, when we see them. It aligns for with the swagger api, which I think will be good in training scenarios and following existing documentation. |
jamshale
reviewed
Dec 6, 2023
jamshale
previously approved these changes
Dec 6, 2023
Sure thing I'll try adding them now |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
jamshale
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves #921 by introducing a standard way to toggle between the json representation of a schema as seen below.
*: For consistency invalid JSON is not allowed in this new component. How this error is indicated will be handled by the parent components.
Regular representation:
JSON representation:
The two are always kept in sync when switching. This way users can enter
some fields via the JSON view and other fields using the regular list view.
Here is an example of the attribute list being updated and reflected in the regular list view.
Change made in the JSON view:
Resulting change seen in the list view:
To reduce duplication of code I have adapted the code used in
EnterCredentialValues.vueand extracted the functionality of toggling to a JSON view into it's own common componentToggleJson.