Add email contact to tenants #959
Conversation
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Deployment URLs ready for review. |
There was a problem hiding this comment.
Looks good, I like the flow that it takes the contact email from the reservation and then the tenant record itself (rather than the reservation) is what gets updated by the user themself.
Couple minor comments in code.
One thing we could also consider I think is adding the contact_email to the table itself so the Innkeeper can see it at-a-glance? Unless anyone else reading doesn't think that's useful for the screen real estate.
plugins/traction_innkeeper/traction_innkeeper/v1_0/innkeeper/tenant_manager.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
…to add-email-contact-to-tenants
|
The innkeeper can now view and contact tenants email's via the tenant view
The link is a |
@Gavinok oh nice call! Minor-est quibble but can we move the email column one over to the left, just because (unless there's additional row actions like the schema one) all the created/updated dates are the rightmost column in the tables. |
|
@loneil how does this look? |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
This PR resolves #900
Emails are now tied to a tenant upon creation and can be viewed in the Profile page
In the Settings tenants can change the email associated with their tenant
Finally the innkeeper can view this email when inspecting the raw content of a tenant