Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grubport snippet fails for RHEL9 #242

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

cbouchar
Copy link
Contributor

Beaker users reported grub.cfg files being overwritten by Beaker causing job failures. I determined that this occurs only when the system is configured with
Install Options --> Kickstart Metadata --> grubport=0x03f8
This grubport config causes the grubport snippet to expand in the kickstart file. When looking at the two possible grub.cfg files, it looks like RHEL team now using /boot/efi/EFI/redhat/grub.cfg as a programmable link to /boot/grub2/grub.cfg file. To continue to support configuration of serial port, this changeset will only try to configure /boot/grub2/grub.cfg for RHEL9. All other distros will remain the unchanged.

Beaker users reported grub.cfg files being overwritten by Beaker
causing job failures.  I determined that this occurs only when
the system is configured with
    Install Options --> Kickstart Metadata --> grubport=0x03f8
This grubport config causes the grubport snippet to expand in the
kickstart file.  When looking at the two possible grub.cfg files,
it looks like RHEL team now using /boot/efi/EFI/redhat/grub.cfg as a
programmable link to /boot/grub2/grub.cfg file. To continue to
support configuration of serial port, this changeset will only try
to configure /boot/grub2/grub.cfg for RHEL9.  All other distros will
remain the unchanged.
Copy link
Collaborator

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @cbouchar

Copy link
Contributor

@StykMartin StykMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to check this again once we can properly integrate CentOS Stream.

@cbouchar
Copy link
Contributor Author

@StykMartin FYI People have been testing with CentOSStream here at RH using Beaker. I don't think that was the case when you were at RH.

@StykMartin
Copy link
Contributor

It was, but the problem is that CS8/9/10 doesn't provide the right metadata to create a proper distribution, and manual import was required. Anyway. This patch fixes the problem with RHEL, but we should see the same problem with CS9/CS10, and I wonder why we are only addressing RHEL.

@cbouchar
Copy link
Contributor Author

cbouchar commented Dec 2, 2024

When I applied this fix, I had tested with CentOSStream9 without any failures. This work was done so long ago I honestly don't recall the details. No one has complained about CentOSStream distros which are not affected by the change.

@StykMartin StykMartin merged commit 97c7855 into beaker-project:python-3 Dec 3, 2024
20 checks passed
@cbouchar
Copy link
Contributor Author

cbouchar commented Dec 3, 2024

On know you merged but I dug up more details:
grub2 on x86_64 UEFI systems attempts to load grubenv file from the same place where the grub2 binary is loaded which is /boot/efi, but the grubenv file is located at /boot/grub2/grubenv
Error seen during boot is: error: ../../grub-core/fs/fshelp.c:257:file `/EFI/redhat/grubenv' not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants