-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grubport snippet fails for RHEL9 #242
grubport snippet fails for RHEL9 #242
Conversation
Beaker users reported grub.cfg files being overwritten by Beaker causing job failures. I determined that this occurs only when the system is configured with Install Options --> Kickstart Metadata --> grubport=0x03f8 This grubport config causes the grubport snippet to expand in the kickstart file. When looking at the two possible grub.cfg files, it looks like RHEL team now using /boot/efi/EFI/redhat/grub.cfg as a programmable link to /boot/grub2/grub.cfg file. To continue to support configuration of serial port, this changeset will only try to configure /boot/grub2/grub.cfg for RHEL9. All other distros will remain the unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @cbouchar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to check this again once we can properly integrate CentOS Stream.
@StykMartin FYI People have been testing with CentOSStream here at RH using Beaker. I don't think that was the case when you were at RH. |
It was, but the problem is that CS8/9/10 doesn't provide the right metadata to create a proper distribution, and manual import was required. Anyway. This patch fixes the problem with RHEL, but we should see the same problem with CS9/CS10, and I wonder why we are only addressing RHEL. |
When I applied this fix, I had tested with CentOSStream9 without any failures. This work was done so long ago I honestly don't recall the details. No one has complained about CentOSStream distros which are not affected by the change. |
On know you merged but I dug up more details: |
Beaker users reported grub.cfg files being overwritten by Beaker causing job failures. I determined that this occurs only when the system is configured with
Install Options --> Kickstart Metadata --> grubport=0x03f8
This grubport config causes the grubport snippet to expand in the kickstart file. When looking at the two possible grub.cfg files, it looks like RHEL team now using /boot/efi/EFI/redhat/grub.cfg as a programmable link to /boot/grub2/grub.cfg file. To continue to support configuration of serial port, this changeset will only try to configure /boot/grub2/grub.cfg for RHEL9. All other distros will remain the unchanged.