beaker-refresh-ldap fails - user lacks email addr #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbouchar
requested review from
StykMartin,
JohnVillalovos,
jchristi and
mdujava
jchristi
reviewed
Dec 4, 2024
jchristi
requested changes
Dec 4, 2024
IntegrationTests/src/bkr/inttest/server/tools/test_refresh_ldap.py
Outdated
Show resolved
Hide resolved
JohnVillalovos
approved these changes
Dec 4, 2024
|
I'm scared that based on those test failures that GitHub may have finally killed support for being able to run CentOS 7 😱 |
Some Beaker installations learns user via ldap groups. One user
did not have an email address resulting in beaker-refresh-ldap
raising an exception:
KeyError: 'mail'. Offending line is here:
File "/usr/lib/python2.7/site-packages/bkr/server/model/identity.py",
line 301, in by_user_name
user.email_address = attrs['mail'][0].decode('utf8')
KeyError: 'mail'
When this exception is encountered, beaker-refresh-ldap stops learning other users.
Fix: When missing any required key attributes (Mail, uid, cn), the user will
not be returned and as a result will not be learned without raising an exception.
This allows beaker-refresh-ldap to continue learning other users.
cbouchar
force-pushed
the
ldap-refresh-fix
branch
from
158d2b7 to
f161e57
Compare
JohnVillalovos
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Beaker installations learns user via ldap groups. One user did not have an email address resulting in beaker-refresh-ldap raising an exception:
KeyError: 'mail'. Offending line is here:
File "/usr/lib/python2.7/site-packages/bkr/server/model/identity.py",
line 301, in by_user_name
user.email_address = attrs['mail'][0].decode('utf8')
KeyError: 'mail'
When this exception is encountered, beaker-refresh-ldap stops learning other users. Fix: When missing any required key attributes (Mail, uid, cn), the user will not be returned and as a result will not be learned without raising an exception. This allows beaker-refresh-ldap to continue learning other users.