Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chord): allow downloading DATS JSON as attachment #545

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat(chord): allow downloading DATS JSON as attachment #545

merged 4 commits into from
Sep 30, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (9c666ba) to head (e5a3a8e).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #545      +/-   ##
===========================================
+ Coverage    90.90%   90.92%   +0.01%     
===========================================
  Files          127      127              
  Lines         4893     4903      +10     
  Branches       693      693              
===========================================
+ Hits          4448     4458      +10     
  Misses         299      299              
  Partials       146      146

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlougheed davidlougheed changed the title [WIP] feat(chord): allow downloading DATS JSON as attachment feat(chord): allow downloading DATS JSON as attachment Sep 30, 2024
@davidlougheed davidlougheed mentioned this pull request Sep 30, 2024
Merged
@davidlougheed davidlougheed requested a review from gsfk September 30, 2024 17:52
@davidlougheed davidlougheed marked this pull request as ready for review September 30, 2024 17:52
v-rocheleau
v-rocheleau requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor requests, otherwise lgtm

chord_metadata_service/restapi/utils.py Outdated Show resolved Hide resolved
chord_metadata_service/chord/tests/test_api.py Show resolved Hide resolved
chord_metadata_service/patients/api_views.py Show resolved Hide resolved
v-rocheleau
v-rocheleau approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with bento_public PR, lgtm!

gsfk
gsfk approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. I guess there's no better filename than <ugly_id>.json?

@davidlougheed davidlougheed merged commit d98e546 into develop Sep 30, 2024
7 checks passed
@davidlougheed davidlougheed deleted the feat/chord/dats-attachment branch September 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlougheed @gsfk @v-rocheleau