Allows to call weasyprint with file paths #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreiMikhniuk thank you for the contribution! |
|
@AndreiMikhniuk version v4.0.1 has been release with this change. I'm creating release 5.0.0 at the moment to upgrade to .net8 (example projects) and all packages and weasyprint to 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using your wrapper we phased with strange hangs on Linux. It happened even with small 1 page files with few lines of text. We was not able to find the reason of it but passing input\output through files helps.
P.S. I tried to add tests, but they was not working properly: result.Error contains warnings from output. Could be my machine specific. I think some generic things to handle it correctly can be implemented. But it out of the scope the current issue.