Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update declination #515

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis self-assigned this Jan 26, 2025
Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for origin-betaflight-com ready!

Name Link
🔨 Latest commit f7813ee
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-com/deploys/6797a57f0283d70008d19337
😎 Deploy Preview https://deploy-preview-515.dev.web.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis force-pushed the update-declination branch 2 times, most recently from d941571 to 74aaa46 Compare January 26, 2025 18:06
@ot0tot
Copy link
Contributor

ot0tot commented Jan 26, 2025

I believe both of these changes apply to 4.5 also, no?

@haslinghuis
Copy link
Member Author

haslinghuis commented Jan 26, 2025

@ot0tot betaflight/betaflight#14019 has not been back ported to 4.5

@ot0tot
Copy link
Contributor

ot0tot commented Jan 26, 2025

@ot0tot betaflight/betaflight#14019 has not been back ported to 4.5

You are right. I thought I had 4.5.0 checked out when checking, but I was still on master 😅

@@ -1053,6 +1053,10 @@ Array length: 3
mag_declination = 0
Allowed range: 0 - 3599
:::note
Betaflight 4.6 uses allowed range: -300 - 300 for 30 degrees declination.
:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe… range: +300 to -300 for +/-30.0 degrees

Copy link
Member

@nerdCopter nerdCopter Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctzsnooze 's recommendation is more human readable. i suppose it does not matter if negative is before positive (or vice-versa) except that we have ±.

ctzsnooze
ctzsnooze previously approved these changes Jan 27, 2025
@haslinghuis haslinghuis merged commit 8d41f54 into betaflight:master Jan 27, 2025
10 checks passed
@haslinghuis haslinghuis deleted the update-declination branch January 27, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants