Skip to content

Commit

Permalink
fix: updated base contract to add receivers only if receiving chains …
Browse files Browse the repository at this point in the history 
…exist. Added discussion links
  • Loading branch information
@sendra
sendra committed Mar 18, 2024
1 parent fa513d4 commit 1301c5e
Show file tree
Hide file tree
Showing 14 changed files with 18 additions and 26 deletions.
3 changes: 1 addition & 2 deletions ...ntationAndCCIPAdapters/AaveV3Arbitrum_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {BaseCCCImplementationUpdatePayload} from './BaseCCCImplementationUpdateP
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Arbitrum_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseCCCImplementationUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...tationAndCCIPAdapters/AaveV3Avalanche_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import {BaseAdaptersUpdatePayload} from './BaseAdaptersUpdatePayload.sol';
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Avalanche_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseAdaptersUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...plementationAndCCIPAdapters/AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import {BaseAdaptersUpdatePayload} from './BaseAdaptersUpdatePayload.sol';
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseAdaptersUpdatePayload(
Expand Down
2 changes: 1 addition & 1 deletion ...ementationAndCCIPAdapters/AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ contract AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313_Test is BaseT
MiscBNB.PROXY_ADMIN,
type(AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313).creationCode,
'bnb',
36903911
37073128
)
{}
}
3 changes: 1 addition & 2 deletions ...lementationAndCCIPAdapters/AaveV3Base_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {BaseCCCImplementationUpdatePayload} from './BaseCCCImplementationUpdateP
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Base_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseCCCImplementationUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...ntationAndCCIPAdapters/AaveV3Ethereum_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import {BaseAdaptersUpdatePayload} from './BaseAdaptersUpdatePayload.sol';
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Ethereum_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseAdaptersUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...mentationAndCCIPAdapters/AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {BaseCCCImplementationUpdatePayload} from './BaseCCCImplementationUpdateP
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseCCCImplementationUpdatePayload(
Expand Down
2 changes: 1 addition & 1 deletion ...ntationAndCCIPAdapters/AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ contract AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313_Test is
MiscGnosis.PROXY_ADMIN,
type(AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313).creationCode,
'gnosis',
32897310
32990165
)
{

Expand Down
3 changes: 1 addition & 2 deletions ...ementationAndCCIPAdapters/AaveV3Metis_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {BaseCCCImplementationUpdatePayload} from './BaseCCCImplementationUpdateP
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Metis_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseCCCImplementationUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...ntationAndCCIPAdapters/AaveV3Optimism_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {BaseCCCImplementationUpdatePayload} from './BaseCCCImplementationUpdateP
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Optimism_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseCCCImplementationUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...entationAndCCIPAdapters/AaveV3Polygon_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import {BaseAdaptersUpdatePayload} from './BaseAdaptersUpdatePayload.sol';
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Polygon_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseAdaptersUpdatePayload(
Expand Down
3 changes: 1 addition & 2 deletions ...mentationAndCCIPAdapters/AaveV3Scroll_UpdateADIImplementationAndCCIPAdapters_20240313.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {BaseCCCImplementationUpdatePayload} from './BaseCCCImplementationUpdateP
/**
* @title aDI and bridge adapters update
* @author BGD Labs @bgdlabs
* - Snapshot: TODO
* - Discussion: TODO
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21
*/
contract AaveV3Scroll_UpdateADIImplementationAndCCIPAdapters_20240313 is
BaseCCCImplementationUpdatePayload(
Expand Down
5 changes: 4 additions & 1 deletion src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/BaseAdaptersUpdatePayload.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,16 @@ abstract contract BaseAdaptersUpdatePayload is BaseCCCImplementationUpdatePayloa
);

uint256[] memory chainsToSend = getChainsToSend();
uint256[] memory chainsToReceive = getChainsToReceive();

if (chainsToSend.length != 0) {
if (chainsToReceive.length != 0) {
// add receiver adapters
ICrossChainReceiver(CROSS_CHAIN_CONTROLLER).allowReceiverBridgeAdapters(
getReceiverBridgeAdaptersToAllow()
);
}

if (chainsToSend.length != 0) {
// add forwarding adapters
ICrossChainForwarder(CROSS_CHAIN_CONTROLLER).enableBridgeAdapters(
getForwarderBridgeAdaptersToEnable()
Expand Down
5 changes: 2 additions & 3 deletions ...pdateADIImplementationAndCCIPAdapters/UpdateADIImplementationAndCCIPAdapters.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "Update a.DI implementation and CCIP adapters"
author: "BGD Labs @bgdlabs"
discussions: ""
discussions: "https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21"
---

## Simple Summary
Expand Down Expand Up @@ -51,8 +51,7 @@ Updates the bridge adapters used to connect between networks
- Implementation: [AaveV3Ethereum](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Ethereum_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Polygon](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Polygon_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Avalanche](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Avalanche_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Optimism](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Optimism_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Arbitrum](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Arbitrum_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Metis](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Metis_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Base](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Base_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Gnosis](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3Scroll](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Scroll_UpdateADIImplementationAndCCIPAdapters_20240313.sol), [AaveV3BNB](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313.sol)
- Tests: [AaveV3Ethereum](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Ethereum_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Polygon](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Polygon_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Avalanche](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Avalanche_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Optimism](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Optimism_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Arbitrum](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Arbitrum_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Metis](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Metis_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Base](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Base_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Gnosis](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3Scroll](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3Scroll_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol), [AaveV3BNB](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313.t.sol)
-
- [Snapshot](TODO)
- [Discussion](TODO)
- [Discussion](https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/21)

## Copyright

Expand Down

0 comments on commit 1301c5e

Please sign in to comment.