Skip to content

Commit

Permalink
ci: fix replace aave-proposals-v3 with v3, not v2
Browse files Browse the repository at this point in the history
  • Loading branch information
sakulstra committed Nov 1, 2023
1 parent 15c532d commit 537090f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ipfs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ jobs:
for i in "${json_array[@]}"
do
npx prettier $i --write
sed -i 's@https://github.com/bgd-labs/aave-proposals-v3/blob/main/@https://github.com/bgd-labs/aave-proposals/blob/${{ github.sha }}/@g' $i
sed -i 's@https://github.com/bgd-labs/aave-proposals-v3/tree/main/@https://github.com/bgd-labs/aave-proposals/blob/${{ github.sha }}/@g' $i
sed -i 's@https://github.com/bgd-labs/aave-proposals-v3/blob/main/@https://github.com/bgd-labs/aave-proposals-v3/blob/${{ github.sha }}/@g' $i
sed -i 's@https://github.com/bgd-labs/aave-proposals-v3/tree/main/@https://github.com/bgd-labs/aave-proposals-v3/blob/${{ github.sha }}/@g' $i
done
- name: Upload
Expand Down
6 changes: 4 additions & 2 deletions src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ The ACI, as one of the voices for the Aave DAO, has consistently worked towards

The ACI will continue to be one of the voices of Aave across the globe, supporting devs in hackathons, being one of the DAO voices during events and supporting our brand quality.



## Specification

- **Recipient**: [0x57ab7ee15cE5ECacB1aB84EE42D5A9d0d8112922](https://etherscan.io/address/0x57ab7ee15cE5ECacB1aB84EE42D5A9d0d8112922)
Expand All @@ -86,8 +88,8 @@ The ACI will continue to be one of the voices of Aave across the globe, supporti

## References

- Implementation: [AaveV3Ethereum](https://github.com/bgd-labs/aave-proposals/blob/a0fc52e0429fadd9fa43a77873ffa7b086f05b75/src/20231029_AaveV3Ethereum_ACIPhaseII/AaveV3Ethereum_ACIPhaseII_20231029.sol)
- Tests: [AaveV3Ethereum](https://github.com/bgd-labs/aave-proposals/blob/a0fc52e0429fadd9fa43a77873ffa7b086f05b75/src/20231029_AaveV3Ethereum_ACIPhaseII/AaveV3Ethereum_ACIPhaseII_20231029.t.sol)
- Implementation: [AaveV3Ethereum](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20231029_AaveV3Ethereum_ACIPhaseII/AaveV3Ethereum_ACIPhaseII_20231029.sol)
- Tests: [AaveV3Ethereum](https://github.com/bgd-labs/aave-proposals-v3/blob/main/src/20231029_AaveV3Ethereum_ACIPhaseII/AaveV3Ethereum_ACIPhaseII_20231029.t.sol)
- [Snapshot](https://signal.aave.com/#/proposal/0x04e7059fc5b2c33d4e4554d68d27ef67c1f6d9d310b07493116bdfbf15c25bbc)
- [Discussion](https://governance.aave.com/t/arfc-aci-phase-ii/15138)

Expand Down

1 comment on commit 537090f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foundry report

forge 0.2.0 (799b820 2023-11-01T00:30:43.361383120Z)
Build log
installing solc version "0.8.22"
Successfully installed solc 0.8.22
Compiling 101 files with 0.8.22
Solc 0.8.22 finished in 15.34s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/aave-helpers/src/GovV3Helpers.sol:732:5:
    |
732 |     address votingPortal
    |     ^^^^^^^^^^^^^^^^^^^^

| Contract                           | Size (kB) | Margin (kB) |
|------------------------------------|-----------|-------------|
| AaveGovernanceV2                   | 0.086     | 24.49       |
| AaveV2Avalanche                    | 0.086     | 24.49       |
| AaveV2AvalancheAssets              | 0.086     | 24.49       |
| AaveV2Ethereum                     | 0.086     | 24.49       |
| AaveV2EthereumAMM                  | 0.086     | 24.49       |
| AaveV2EthereumAMMAssets            | 0.086     | 24.49       |
| AaveV2EthereumAssets               | 0.086     | 24.49       |
| AaveV2Polygon                      | 0.086     | 24.49       |
| AaveV2PolygonAssets                | 0.086     | 24.49       |
| AaveV3Arbitrum                     | 0.086     | 24.49       |
| AaveV3ArbitrumAssets               | 0.086     | 24.49       |
| AaveV3ArbitrumEModes               | 0.086     | 24.49       |
| AaveV3Avalanche                    | 0.086     | 24.49       |
| AaveV3AvalancheAssets              | 0.086     | 24.49       |
| AaveV3AvalancheEModes              | 0.086     | 24.49       |
| AaveV3Ethereum                     | 0.086     | 24.49       |
| AaveV3EthereumAssets               | 0.086     | 24.49       |
| AaveV3EthereumEModes               | 0.086     | 24.49       |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682     | 23.894      |
| AaveV3Fantom                       | 0.086     | 24.49       |
| AaveV3FantomAssets                 | 0.086     | 24.49       |
| AaveV3FantomEModes                 | 0.086     | 24.49       |
| AaveV3Harmony                      | 0.086     | 24.49       |
| AaveV3HarmonyAssets                | 0.086     | 24.49       |
| AaveV3HarmonyEModes                | 0.086     | 24.49       |
| AaveV3Optimism                     | 0.086     | 24.49       |
| AaveV3OptimismAssets               | 0.086     | 24.49       |
| AaveV3OptimismEModes               | 0.086     | 24.49       |
| AaveV3Polygon                      | 0.086     | 24.49       |
| AaveV3PolygonAssets                | 0.086     | 24.49       |
| AaveV3PolygonEModes                | 0.086     | 24.49       |
| Address                            | 0.086     | 24.49       |
| ChainHelpers                       | 0.086     | 24.49       |
| ChainIds                           | 0.086     | 24.49       |
| ConfiguratorInputTypes             | 0.086     | 24.49       |
| Create2Utils                       | 0.164     | 24.412      |
| DataTypes                          | 0.086     | 24.49       |
| Errors                             | 4.715     | 19.861      |
| GovHelpers                         | 0.086     | 24.49       |
| GovV3Helpers                       | 0.086     | 24.49       |
| GovV3StorageHelpers                | 0.086     | 24.49       |
| GovernanceV3Arbitrum               | 0.086     | 24.49       |
| GovernanceV3Avalanche              | 0.086     | 24.49       |
| GovernanceV3BNB                    | 0.086     | 24.49       |
| GovernanceV3Base                   | 0.086     | 24.49       |
| GovernanceV3Ethereum               | 0.086     | 24.49       |
| GovernanceV3Gnosis                 | 0.086     | 24.49       |
| GovernanceV3Metis                  | 0.086     | 24.49       |
| GovernanceV3Optimism               | 0.086     | 24.49       |
| GovernanceV3Polygon                | 0.086     | 24.49       |
| IpfsUtils                          | 0.086     | 24.49       |
| MiscEthereum                       | 0.086     | 24.49       |
| MockExecutor                       | 0.437     | 24.139      |
| PayloadsControllerUtils            | 0.086     | 24.49       |
| ProxyHelpers                       | 0.086     | 24.49       |
| ReserveConfiguration               | 0.171     | 24.405      |
| SafeERC20                          | 0.086     | 24.49       |
| StdStyle                           | 0.086     | 24.49       |
| StorageHelpers                     | 0.086     | 24.49       |
| console                            | 0.086     | 24.49       |
| console2                           | 0.086     | 24.49       |
| safeconsole                        | 0.086     | 24.49       |
| stdError                           | 0.592     | 23.984      |
| stdJson                            | 0.086     | 24.49       |
| stdMath                            | 0.086     | 24.49       |
| stdStorage                         | 0.086     | 24.49       |
| stdStorageSafe                     | 0.086     | 24.49       |
Test success 🌈

Please sign in to comment.