chore: validate result of transfer

bgd-labs · Feb 22, 2024 · b0ad5aa · b0ad5aa
1 parent d8fff3b
commit b0ad5aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/20240220_AaveV3Ethereum_OrbitProgram/AaveV3Ethereum_OrbitProgram_20240220.sol b/src/20240220_AaveV3Ethereum_OrbitProgram/AaveV3Ethereum_OrbitProgram_20240220.sol
@@ -20,6 +20,8 @@ interface IWETH {
  * - Discussion: https://governance.aave.com/t/arfc-orbit-program-renewal/16550
  */
 contract AaveV3Ethereum_OrbitProgram_20240220 is IProposalGenericExecutor {
+  error EthTransferFailed(address account);
+
   function execute() external {
     AaveV3Ethereum.COLLECTOR.transfer(
       AaveV3EthereumAssets.WETH_UNDERLYING,
@@ -33,6 +35,7 @@ contract AaveV3Ethereum_OrbitProgram_20240220 is IProposalGenericExecutor {
     uint256 usageLength = usage.length;
     for (uint256 i = 0; i < usageLength; i++) {
       (bool ok, ) = usage[i].account.call{value: usage[i].usage}('');
+      if (!ok) revert EthTransferFailed(usage[i].account);
     }
 
     uint256 actualStreamAmount = (OrbitProgramData.STREAM_AMOUNT /

diff --git a/src/20240220_AaveV3Ethereum_OrbitProgram/AaveV3Ethereum_OrbitProgram_20240220.t.sol b/src/20240220_AaveV3Ethereum_OrbitProgram/AaveV3Ethereum_OrbitProgram_20240220.t.sol
@@ -1,5 +1,4 @@
 // SPDX-License-Identifier: MIT
-
 pragma solidity ^0.8.0;
 
 import {AaveV3Ethereum, AaveV3EthereumAssets} from 'aave-address-book/AaveV3Ethereum.sol';