fix: give pool admin role just to be consistent with the deployed ste…

…wards
bgd-labs · Mar 28, 2024 · c6a110f · c6a110f
1 parent b28b187
commit c6a110f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...240326_AaveV3Ethereum_ActivateGhoStewards/AaveV3Ethereum_ActivateGhoStewards_20240326.sol b/...240326_AaveV3Ethereum_ActivateGhoStewards/AaveV3Ethereum_ActivateGhoStewards_20240326.sol
@@ -18,8 +18,8 @@ contract AaveV3Ethereum_ActivateGhoStewards_20240326 is IProposalGenericExecutor
   address public constant GHO_STEWARD = 0x8F2411a538381aae2b464499005F0211e867d84f;
 
   function execute() external {
-    // Give risk admin role to the steward
-    AaveV3Ethereum.ACL_MANAGER.addRiskAdmin(GHO_STEWARD);
+    // Give pool admin role to the steward
+    AaveV3Ethereum.ACL_MANAGER.addPoolAdmin(GHO_STEWARD);
 
     // Give bucket manager role to the steward
     IGhoToken(MiscEthereum.GHO_TOKEN).grantRole(

diff --git a/...0326_AaveV3Ethereum_ActivateGhoStewards/AaveV3Ethereum_ActivateGhoStewards_20240326.t.sol b/...0326_AaveV3Ethereum_ActivateGhoStewards/AaveV3Ethereum_ActivateGhoStewards_20240326.t.sol
@@ -39,7 +39,7 @@ contract AaveV3Ethereum_ActivateGhoStewards_20240326_Test is ProtocolV3TestBase
   function test_adminPermissions() public {
     executePayload(vm, address(proposal));
 
-    assertTrue(AaveV3Ethereum.ACL_MANAGER.isRiskAdmin(proposal.GHO_STEWARD()));
+    assertTrue(AaveV3Ethereum.ACL_MANAGER.isPoolAdmin(proposal.GHO_STEWARD()));
     assertTrue(
       IGhoToken(MiscEthereum.GHO_TOKEN).hasRole(
         IGhoToken(MiscEthereum.GHO_TOKEN).BUCKET_MANAGER_ROLE(),

diff --git a/src/20240326_AaveV3Ethereum_ActivateGhoStewards/ActivateGhoStewards.md b/src/20240326_AaveV3Ethereum_ActivateGhoStewards/ActivateGhoStewards.md
@@ -25,7 +25,7 @@ GHO Stewards consists of members from Growth (ACI), Risk (ChaosLabs) and Finance
 
 The proposal gives the following admin roles:
 
-- Grant GHO Steward the Risk Admin role via the [ACL_MANAGER](https://etherscan.io/address/0xc2aaCf6553D20d1e9d78E365AAba8032af9c85b0) contract.
+- Grant GHO Steward the Pool Admin role via the [ACL_MANAGER](https://etherscan.io/address/0xc2aaCf6553D20d1e9d78E365AAba8032af9c85b0) contract.
 - Grant GHO Steward the Bucket Manager role on the [GHO token](https://etherscan.io/address/0x40D16FC0246aD3160Ccc09B8D0D3A2cD28aE6C2f).
 - Grant GHO Steward the Configurator role on [GSM_USDC](https://etherscan.io/address/0x0d8eFfC11dF3F229AA1EA0509BC9DFa632A13578) and [GSM_USDT](https://etherscan.io/address/0x686F8D21520f4ecEc7ba577be08354F4d1EB8262).
 - Whitelists all the facilitators on the GHO Stewards, including: [GHO_AToken](https://etherscan.io/address/0x00907f9921424583e7ffBfEdf84F92B7B2Be4977), [GHO_FlashMinter](https://etherscan.io/address/0xb639D208Bcf0589D54FaC24E655C79EC529762B8), [GSM_USDC](https://etherscan.io/address/0x0d8eFfC11dF3F229AA1EA0509BC9DFa632A13578), [GSM_USDT](https://etherscan.io/address/0x686F8D21520f4ecEc7ba577be08354F4d1EB8262) - so that the steward has the permissions to update the bucket capacity.