Skip to content

Commit

Permalink
fix: adjust deploy script (#17)
Browse files Browse the repository at this point in the history 
* fix: adjust deploy script

* fix: remove console2
  • Loading branch information
@sakulstra
sakulstra authored Nov 1, 2023
1 parent afd6010 commit e8c80d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion generator/templates/script.template.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function generateScript(options: Options) {
* command: make deploy-ledger contract=src/${folderName}/${fileName}.s.sol:CreateProposal chain=mainnet
*/
contract CreateProposal is EthereumScript {
function run() external broadcast {
function run() external {
// create payloads
PayloadsControllerUtils.Payload[] memory payloads = new PayloadsControllerUtils.Payload[](${
Object.keys(poolsToChainsMap).length
Expand All @@ -93,6 +93,7 @@ contract CreateProposal is EthereumScript {
.join('\n')}
// create proposal
vm.startBroadcast();
GovV3Helpers.createProposal2_5(payloads, GovV3Helpers.ipfsHashFile(vm, 'src/${folderName}/${
options.shortName
}.md'));
Expand Down
3 changes: 2 additions & 1 deletion src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII_20231029.s.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ contract DeployEthereum is EthereumScript {
* command: make deploy-ledger contract=src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII_20231029.s.sol:CreateProposal chain=mainnet
*/
contract CreateProposal is EthereumScript {
function run() external broadcast {
function run() external {
// create payloads
PayloadsControllerUtils.Payload[] memory payloads = new PayloadsControllerUtils.Payload[](1);

Expand All @@ -40,6 +40,7 @@ contract CreateProposal is EthereumScript {
payloads[0] = GovV3Helpers.buildMainnetPayload(vm, actionsEthereum);

// create proposal
vm.startBroadcast();
GovV3Helpers.createProposal2_5(
payloads,
GovV3Helpers.ipfsHashFile(vm, 'src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII.md')
Expand Down

1 comment on commit e8c80d9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foundry report

forge 0.2.0 (799b820 2023-11-01T00:30:43.361383120Z)
Build log 
installing solc version "0.8.22"
Successfully installed solc 0.8.22
Compiling 101 files with 0.8.22
Solc 0.8.22 finished in 19.04s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/aave-helpers/src/GovV3Helpers.sol:732:5:
    |
732 |     address votingPortal
    |     ^^^^^^^^^^^^^^^^^^^^

| Contract                           | Size (kB) | Margin (kB) |
|------------------------------------|-----------|-------------|
| AaveGovernanceV2                   | 0.086     | 24.49       |
| AaveV2Avalanche                    | 0.086     | 24.49       |
| AaveV2AvalancheAssets              | 0.086     | 24.49       |
| AaveV2Ethereum                     | 0.086     | 24.49       |
| AaveV2EthereumAMM                  | 0.086     | 24.49       |
| AaveV2EthereumAMMAssets            | 0.086     | 24.49       |
| AaveV2EthereumAssets               | 0.086     | 24.49       |
| AaveV2Polygon                      | 0.086     | 24.49       |
| AaveV2PolygonAssets                | 0.086     | 24.49       |
| AaveV3Arbitrum                     | 0.086     | 24.49       |
| AaveV3ArbitrumAssets               | 0.086     | 24.49       |
| AaveV3ArbitrumEModes               | 0.086     | 24.49       |
| AaveV3Avalanche                    | 0.086     | 24.49       |
| AaveV3AvalancheAssets              | 0.086     | 24.49       |
| AaveV3AvalancheEModes              | 0.086     | 24.49       |
| AaveV3Ethereum                     | 0.086     | 24.49       |
| AaveV3EthereumAssets               | 0.086     | 24.49       |
| AaveV3EthereumEModes               | 0.086     | 24.49       |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682     | 23.894      |
| AaveV3Fantom                       | 0.086     | 24.49       |
| AaveV3FantomAssets                 | 0.086     | 24.49       |
| AaveV3FantomEModes                 | 0.086     | 24.49       |
| AaveV3Harmony                      | 0.086     | 24.49       |
| AaveV3HarmonyAssets                | 0.086     | 24.49       |
| AaveV3HarmonyEModes                | 0.086     | 24.49       |
| AaveV3Optimism                     | 0.086     | 24.49       |
| AaveV3OptimismAssets               | 0.086     | 24.49       |
| AaveV3OptimismEModes               | 0.086     | 24.49       |
| AaveV3Polygon                      | 0.086     | 24.49       |
| AaveV3PolygonAssets                | 0.086     | 24.49       |
| AaveV3PolygonEModes                | 0.086     | 24.49       |
| Address                            | 0.086     | 24.49       |
| ChainHelpers                       | 0.086     | 24.49       |
| ChainIds                           | 0.086     | 24.49       |
| ConfiguratorInputTypes             | 0.086     | 24.49       |
| Create2Utils                       | 0.164     | 24.412      |
| DataTypes                          | 0.086     | 24.49       |
| Errors                             | 4.715     | 19.861      |
| GovHelpers                         | 0.086     | 24.49       |
| GovV3Helpers                       | 0.086     | 24.49       |
| GovV3StorageHelpers                | 0.086     | 24.49       |
| GovernanceV3Arbitrum               | 0.086     | 24.49       |
| GovernanceV3Avalanche              | 0.086     | 24.49       |
| GovernanceV3BNB                    | 0.086     | 24.49       |
| GovernanceV3Base                   | 0.086     | 24.49       |
| GovernanceV3Ethereum               | 0.086     | 24.49       |
| GovernanceV3Gnosis                 | 0.086     | 24.49       |
| GovernanceV3Metis                  | 0.086     | 24.49       |
| GovernanceV3Optimism               | 0.086     | 24.49       |
| GovernanceV3Polygon                | 0.086     | 24.49       |
| IpfsUtils                          | 0.086     | 24.49       |
| MiscEthereum                       | 0.086     | 24.49       |
| MockExecutor                       | 0.437     | 24.139      |
| PayloadsControllerUtils            | 0.086     | 24.49       |
| ProxyHelpers                       | 0.086     | 24.49       |
| ReserveConfiguration               | 0.171     | 24.405      |
| SafeERC20                          | 0.086     | 24.49       |
| StdStyle                           | 0.086     | 24.49       |
| StorageHelpers                     | 0.086     | 24.49       |
| console                            | 0.086     | 24.49       |
| console2                           | 0.086     | 24.49       |
| safeconsole                        | 0.086     | 24.49       |
| stdError                           | 0.592     | 23.984      |
| stdJson                            | 0.086     | 24.49       |
| stdMath                            | 0.086     | 24.49       |
| stdStorage                         | 0.086     | 24.49       |
| stdStorageSafe                     | 0.086     | 24.49       |
Test success 🌈 



    

  
  




        

      
  

    
  
    
    

  

  




        




  


  
  


  


  


  

    Please
  sign in to comment.