Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust deploy script #17

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: adjust deploy script #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3872b2
fix: adjust deploy script
sakulstra Oct 31, 2023
b8a0bc5
fix: remove console2
sakulstra Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion generator/templates/script.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function generateScript(options: Options) {
* command: make deploy-ledger contract=src/${folderName}/${fileName}.s.sol:CreateProposal chain=mainnet
*/
contract CreateProposal is EthereumScript {
function run() external broadcast {
function run() external {
// create payloads
PayloadsControllerUtils.Payload[] memory payloads = new PayloadsControllerUtils.Payload[](${
Object.keys(poolsToChainsMap).length
Expand All @@ -93,6 +93,7 @@ contract CreateProposal is EthereumScript {
.join('\n')}

// create proposal
vm.startBroadcast();
GovV3Helpers.createProposal2_5(payloads, GovV3Helpers.ipfsHashFile(vm, 'src/${folderName}/${
options.shortName
}.md'));
Expand Down
3 changes: 2 additions & 1 deletion src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII_20231029.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ contract DeployEthereum is EthereumScript {
* command: make deploy-ledger contract=src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII_20231029.s.sol:CreateProposal chain=mainnet
*/
contract CreateProposal is EthereumScript {
function run() external broadcast {
function run() external {
// create payloads
PayloadsControllerUtils.Payload[] memory payloads = new PayloadsControllerUtils.Payload[](1);

Expand All @@ -40,6 +40,7 @@ contract CreateProposal is EthereumScript {
payloads[0] = GovV3Helpers.buildMainnetPayload(vm, actionsEthereum);

// create proposal
vm.startBroadcast();
GovV3Helpers.createProposal2_5(
payloads,
GovV3Helpers.ipfsHashFile(vm, 'src/20231029_AaveV3Ethereum_ACIPhaseII/ACIPhaseII.md')
Expand Down