fix: remove looping hack, as checkbox.required is now a thing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sakulstra
commented
Nov 1, 2023
•
sakulstra
commented
- closes default on select prompts are ignored #5
sakulstra
changed the title
|
Foundry report forge 0.2.0 (85f25c6 2023-11-08T00:21:30.290593993Z)Build logCompiling 151 files with 0.8.19
Solc 0.8.19 finished in 51.22s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
--> lib/aave-helpers/src/GovV3Helpers.sol:730:5:
|
730 | address votingPortal
| ^^^^^^^^^^^^^^^^^^^^
| Contract | Size (kB) | Margin (kB) |
|--------------------------------------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.086 | 24.49 |
| AaveV1Ethereum_FixedREPPriceFeed_20231031 | 0.706 | 23.87 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2AvalancheAssets | 0.086 | 24.49 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumAMMAssets | 0.086 | 24.49 |
| AaveV2EthereumAssets | 0.086 | 24.49 |
| AaveV2Ethereum_AaveV2EthereumLTReduction_20231030 | 3.023 | 21.553 |
| AaveV2Ethereum_Disable_Stable_Borrows_20231104 | 2.519 | 22.057 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV2PolygonAssets | 0.086 | 24.49 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumAssets | 0.086 | 24.49 |
| AaveV3ArbitrumEModes | 0.086 | 24.49 |
| AaveV3Arbitrum_Disable_Stable_Borrows_20231104 | 4.14 | 20.436 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3AvalancheAssets | 0.086 | 24.49 |
| AaveV3AvalancheEModes | 0.086 | 24.49 |
| AaveV3Avalanche_Disable_Stable_Borrows_20231104 | 3.471 | 21.105 |
| AaveV3Ethereum | 0.086 | 24.49 |
| AaveV3EthereumAssets | 0.086 | 24.49 |
| AaveV3EthereumEModes | 0.086 | 24.49 |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682 | 23.894 |
| AaveV3Ethereum_ChaosLabsRiskManagementRenewal_20231101 | 1.014 | 23.562 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomAssets | 0.086 | 24.49 |
| AaveV3FantomEModes | 0.086 | 24.49 |
| AaveV3Gnosis | 0.086 | 24.49 |
| AaveV3GnosisAssets | 0.086 | 24.49 |
| AaveV3GnosisEModes | 0.086 | 24.49 |
| AaveV3Gnosis_AaveV3GnosisActivation_20231026 | 8.802 | 15.774 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3HarmonyAssets | 0.086 | 24.49 |
| AaveV3HarmonyEModes | 0.086 | 24.49 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismAssets | 0.086 | 24.49 |
| AaveV3OptimismEModes | 0.086 | 24.49 |
| AaveV3Optimism_Disable_Stable_Borrows_20231104 | 3.851 | 20.725 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonAssets | 0.086 | 24.49 |
| AaveV3PolygonEModes | 0.086 | 24.49 |
| AaveV3Polygon_Disable_Stable_Borrows_20231104 | 4.139 | 20.437 |
| Address | 0.086 | 24.49 |
| ChainHelpers | 0.086 | 24.49 |
| ChainIds | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| Create2Utils | 0.164 | 24.412 |
| DataTypes | 0.086 | 24.49 |
| EngineFlags | 0.086 | 24.49 |
| Errors | 4.714 | 19.862 |
| GovHelpers | 0.086 | 24.49 |
| GovV3Helpers | 0.086 | 24.49 |
| GovV3StorageHelpers | 0.086 | 24.49 |
| GovernanceV3Arbitrum | 0.086 | 24.49 |
| GovernanceV3Avalanche | 0.086 | 24.49 |
| GovernanceV3BNB | 0.086 | 24.49 |
| GovernanceV3Base | 0.086 | 24.49 |
| GovernanceV3Ethereum | 0.086 | 24.49 |
| GovernanceV3Gnosis | 0.086 | 24.49 |
| GovernanceV3Metis | 0.086 | 24.49 |
| GovernanceV3Optimism | 0.086 | 24.49 |
| GovernanceV3Polygon | 0.086 | 24.49 |
| IpfsUtils | 0.086 | 24.49 |
| MiscEthereum | 0.086 | 24.49 |
| MockExecutor | 0.437 | 24.139 |
| PayloadsControllerUtils | 0.086 | 24.49 |
| ProxyHelpers | 0.086 | 24.49 |
| ReserveConfiguration | 0.171 | 24.405 |
| SafeERC20 | 0.086 | 24.49 |
| StdStyle | 0.086 | 24.49 |
| StorageHelpers | 0.086 | 24.49 |
| WadRayMath | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| safeconsole | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 |Test success 🌈 |
still blocked as no new version of checkbox is yet released SBoudrias/Inquirer.js@6fb4d9c
sakulstra
force-pushed
the
fix/remove-loop-hack
branch
from
6bbf273 to
730c3fd
Compare
sendra
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.