Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arb isolation #256

Merged
merged 20 commits into from
Mar 25, 2024

Conversation

efecarranza
Copy link
Contributor

Changelog

Remove debt-ceiling from ARB on Arbitrum v3.

lib/aave-helpers Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efecarranza can you update with main, i think aave-helpers lib should be already on the latest commit

Copy link
Contributor

@brotherlymite brotherlymite Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it is the reason the compilation is breaking also

Copy link

Foundry report

forge 0.2.0 (88e09f6 2024-03-25T00:19:03.528235881Z)
Build log
Compiling 462 files with 0.8.19
Solc 0.8.19 finished in 309.54s
Compiler run successful with warnings:
Warning (3628): This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
  --> src/20240218_AaveV1Ethereum_AaveV1DeprecationPhase2/AaveV1Ethereum_AaveV1Deprecation_20240218.t.sol:86:1:
   |
86 | contract AaveV1Ethereum_AaveV1Deprecation_20240218_Test is ProtocolV2TestBase {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: The payable fallback function is defined here.
   --> src/20240218_AaveV1Ethereum_AaveV1DeprecationPhase2/AaveV1Ethereum_AaveV1Deprecation_20240218.t.sol:232:3:
    |
232 |   fallback() external payable {}
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning (9302): Return value of low-level calls not used.
  --> src/20231229_Multi_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1/AaveV2Ethereum_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1_20231229.sol:47:5:
   |
47 |     SAFE.call{value: address(this).balance}('');
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:32:3:
   |
32 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:43:3:
   |
43 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:54:3:
   |
54 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:65:3:
   |
65 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:76:3:
   |
76 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:87:3:
   |
87 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240104_Multi_Patch/Patch_20240104.s.sol:98:3:
   |
98 |   function _getPayload() internal override returns (bytes memory) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
   --> src/20240218_AaveV1Ethereum_AaveV1DeprecationPhase2/AaveV1Ethereum_AaveV1Deprecation_20240218.t.sol:207:3:
    |
207 |   function _getUsers() internal returns (V1User[] memory) {
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240308_AaveV3Ethereum_GHOBorrowRateIncrease/GhoInterestRateStrategy.sol:67:3:
   |
67 |   function getBaseVariableBorrowRate() external view override returns (uint256) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240308_AaveV3Ethereum_GHOBorrowRateIncrease/GhoInterestRateStrategy.sol:72:3:
   |
72 |   function getMaxVariableBorrowRate() external view override returns (uint256) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240308_AaveV3Ethereum_GHOBorrowRateIncrease/GhoInterestRateStrategy.sol:77:3:
   |
77 |   function calculateInterestRates(
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
  --> src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/BaseTest.sol:91:3:
   |
91 |   function getTrustedRemoteByChainId(uint256 chainId) public view returns (address) {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to view
   --> src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/BaseTest.sol:316:3:
    |
316 |   function _getCurrentForwarderAdaptersByChain() internal returns (ForwarderAdapters[] memory) {
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to view
   --> src/20240313_Multi_UpdateADIImplementationAndCCIPAdapters/BaseTest.sol:341:3:
    |
341 |   function _getCurrentReceiverAdaptersByChain() internal returns (AdaptersByChain[] memory) {
    |   ^ (Relevant source part starts here and spans across multiple lines).

| Contract                                                                                                 | Size (kB) | Margin (kB) |
|----------------------------------------------------------------------------------------------------------|-----------|-------------|
| AaveGovernanceV2                                                                                         | 0.045     | 24.531      |
| AaveSafetyModule                                                                                         | 0.045     | 24.531      |
| AaveSwapper                                                                                              | 5.572     | 19.004      |
| AaveV1Ethereum_AaveV1Deprecation_20240218                                                                | 0.297     | 24.279      |
| AaveV2Avalanche                                                                                          | 0.045     | 24.531      |
| AaveV2AvalancheAssets                                                                                    | 0.045     | 24.531      |
| AaveV2Avalanche_ChaosLabsRiskParameterUpdatesWBTCEOnV2AndV3Avalanche_20231221                            | 0.336     | 24.24       |
| AaveV2Avalanche_StablecoinIRCurvesUpdates_20231221                                                       | 1.858     | 22.718      |
| AaveV2Ethereum                                                                                           | 0.045     | 24.531      |
| AaveV2EthereumAMM                                                                                        | 0.045     | 24.531      |
| AaveV2EthereumAMMAssets                                                                                  | 0.045     | 24.531      |
| AaveV2EthereumAMM_ARFCDeprecateAaveV2AMMMarketStep2_20240205                                             | 2.894     | 21.682      |
| AaveV2EthereumAssets                                                                                     | 0.045     | 24.531      |
| AaveV2Ethereum_AMPLInterestRateUpdatesOnV2Ethereum_20240121                                              | 1.602     | 22.974      |
| AaveV2Ethereum_ChaosLabsV2EthereumLTReductions_20240201                                                  | 0.926     | 23.65       |
| AaveV2Ethereum_EthereumV2ReserveFactorAdjustment_20240304                                                | 4.904     | 19.672      |
| AaveV2Ethereum_EthereumV2ReserveFactorAdjustment_20240320                                                | 1.778     | 22.798      |
| AaveV2Ethereum_MigrationOfRemainingGovV2Permissions_20240130                                             | 0.977     | 23.599      |
| AaveV2Ethereum_MigrationOfRemainingGovV2Permissions_Part2_20240130                                       | 1.446     | 23.13       |
| AaveV2Ethereum_StablecoinIRCurvesUpdates_20231221                                                        | 2.839     | 21.737      |
| AaveV2Ethereum_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1_20231229                         | 3.415     | 21.161      |
| AaveV2Ethereum_V2DeprecationPlan20240102_20240103                                                        | 0.927     | 23.649      |
| AaveV2Polygon                                                                                            | 0.045     | 24.531      |
| AaveV2PolygonAssets                                                                                      | 0.045     | 24.531      |
| AaveV2Polygon_ReserveFactorUpdatesFebruary152024_20240208                                                | 0.831     | 23.745      |
| AaveV2Polygon_ReserveFactorUpdatesFebruary292024_20240229                                                | 0.683     | 23.893      |
| AaveV2Polygon_ReserveFactorUpdatesJan152024_20240108                                                     | 1.134     | 23.442      |
| AaveV2Polygon_ReserveFactorUpdatesJan312024_20240125                                                     | 0.831     | 23.745      |
| AaveV2Polygon_ReserveFactorUpdates_20240102                                                              | 0.995     | 23.581      |
| AaveV2Polygon_ReserveFactorUpdates_20240313                                                              | 0.535     | 24.041      |
| AaveV2Polygon_StablecoinIRCurvesUpdates_20231221                                                         | 1.858     | 22.718      |
| AaveV3Arbitrum                                                                                           | 0.045     | 24.531      |
| AaveV3ArbitrumAssets                                                                                     | 0.045     | 24.531      |
| AaveV3ArbitrumEModes                                                                                     | 0.045     | 24.531      |
| AaveV3Arbitrum_ARBRemoveIsolation_20240315                                                               | 0.193     | 24.383      |
| AaveV3Arbitrum_AaveProtocolEmbassy_20240220                                                              | 0.435     | 24.141      |
| AaveV3Arbitrum_AddFlashborrowers_20240306                                                                | 0.25      | 24.326      |
| AaveV3Arbitrum_AssignEmissionAdminEthereumArbitrumAndOptimism_20240229                                   | 0.323     | 24.253      |
| AaveV3Arbitrum_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                       | 3.362     | 21.214      |
| AaveV3Arbitrum_Patch_20240104                                                                            | 0.479     | 24.097      |
| AaveV3Arbitrum_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206                 | 0.212     | 24.364      |
| AaveV3Arbitrum_StablecoinHarmonization_20240312                                                          | 4.469     | 20.107      |
| AaveV3Arbitrum_StablecoinIRCurvesUpdates_20231221                                                        | 4.878     | 19.698      |
| AaveV3Arbitrum_UpdateADIImplementationAndCCIPAdapters_20240313                                           | 0.588     | 23.988      |
| AaveV3Arbitrum_UpdateStETHAndWETHRiskParamsOnAaveV3EthereumOptimismAndArbitrum_20240121                  | 3.892     | 20.684      |
| AaveV3Arbitrum_UpdateWETHIROnV3ArbitrumAndOptimism_20240216                                              | 3.622     | 20.954      |
| AaveV3Avalanche                                                                                          | 0.045     | 24.531      |
| AaveV3AvalancheAssets                                                                                    | 0.045     | 24.531      |
| AaveV3AvalancheEModes                                                                                    | 0.045     | 24.531      |
| AaveV3Avalanche_ChaosLabsRiskParameterUpdatesWBTCEOnV2AndV3Avalanche_20231221                            | 3.513     | 21.063      |
| AaveV3Avalanche_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                      | 3.377     | 21.199      |
| AaveV3Avalanche_Patch_20240104                                                                           | 0.479     | 24.097      |
| AaveV3Avalanche_StablecoinHarmonization_20240312                                                         | 3.983     | 20.593      |
| AaveV3Avalanche_StablecoinIRCurvesUpdates_20231221                                                       | 4.628     | 19.948      |
| AaveV3Avalanche_UpdateADIImplementationAndCCIPAdapters_20240313                                          | 3.292     | 21.284      |
| AaveV3BNB                                                                                                | 0.045     | 24.531      |
| AaveV3BNBAssets                                                                                          | 0.045     | 24.531      |
| AaveV3BNBEModes                                                                                          | 0.045     | 24.531      |
| AaveV3BNB_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                            | 3.38      | 21.196      |
| AaveV3BNB_OnboardFdUSDToAaveV3OnBSC_20240201                                                             | 5.014     | 19.562      |
| AaveV3BNB_SetAaveChanInitiativeAsEmissionManagerForFdUSDOnBNBChainAaveV3_20240208                        | 0.212     | 24.364      |
| AaveV3BNB_UpdateADIImplementationAndCCIPAdapters_20240313                                                | 3.084     | 21.492      |
| AaveV3Base                                                                                               | 0.045     | 24.531      |
| AaveV3BaseAssets                                                                                         | 0.045     | 24.531      |
| AaveV3BaseEModes                                                                                         | 0.045     | 24.531      |
| AaveV3Base_Patch_20240104                                                                                | 0.479     | 24.097      |
| AaveV3Base_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206                     | 0.212     | 24.364      |
| AaveV3Base_StablecoinIRCurvesUpdates_20231221                                                            | 3.618     | 20.958      |
| AaveV3Base_UpdateADIImplementationAndCCIPAdapters_20240313                                               | 0.588     | 23.988      |
| AaveV3Ethereum                                                                                           | 0.045     | 24.531      |
| AaveV3EthereumAssets                                                                                     | 0.045     | 24.531      |
| AaveV3EthereumEModes                                                                                     | 0.045     | 24.531      |
| AaveV3Ethereum_AaveLiquidityCommiteeFunding_20240306                                                     | 1.964     | 22.612      |
| AaveV3Ethereum_ActivationOfACPrimeFoundation_20240308                                                    | 0.502     | 24.074      |
| AaveV3Ethereum_AddFlashborrowers_20240306                                                                | 1.223     | 23.353      |
| AaveV3Ethereum_AddPYUSDToAaveV3EthereumMarket_20240125                                                   | 4.993     | 19.583      |
| AaveV3Ethereum_AmendSafetyModuleEmissions_20240229                                                       | 2.399     | 22.177      |
| AaveV3Ethereum_AssignEmissionAdminEthereumArbitrumAndOptimism_20240229                                   | 0.967     | 23.609      |
| AaveV3Ethereum_ChaosLabsRiskParameterUpdatesIncreaseDebtCeilingForSNXAndMKROnV3Ethereum01312024_20240211 | 3.533     | 21.043      |
| AaveV3Ethereum_CutGauntletServiceProviderStream_20240227                                                 | 0.479     | 24.097      |
| AaveV3Ethereum_FundingUpdate_20240224                                                                    | 10.54     | 14.036      |
| AaveV3Ethereum_GHOBorrowRateIncrease20240229_20240229                                                    | 0.285     | 24.291      |
| AaveV3Ethereum_GHOBorrowRateIncrease_20240308                                                            | 0.233     | 24.343      |
| AaveV3Ethereum_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                       | 3.376     | 21.2        |
| AaveV3Ethereum_MeritApprovals_20240306                                                                   | 0.534     | 24.042      |
| AaveV3Ethereum_OrbitProgram_20240220                                                                     | 2.308     | 22.268      |
| AaveV3Ethereum_Patch_20240104                                                                            | 0.479     | 24.097      |
| AaveV3Ethereum_RegisterADIScrollAdapter_20240122                                                         | 0.63      | 23.946      |
| AaveV3Ethereum_RequestForBountyPayoutJanuary2024_20240125                                                | 0.781     | 23.795      |
| AaveV3Ethereum_RetroactiveBugBountyPreImmunefi_20240205                                                  | 0.782     | 23.794      |
| AaveV3Ethereum_SecurityBudgetRequestDecember2023_20240206                                                | 0.514     | 24.062      |
| AaveV3Ethereum_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206                 | 0.212     | 24.364      |
| AaveV3Ethereum_StableRateBugBounty_20240207                                                              | 0.768     | 23.808      |
| AaveV3Ethereum_StablecoinHarmonization_20240312                                                          | 5.299     | 19.277      |
| AaveV3Ethereum_StablecoinIRCurvesUpdates_20231221                                                        | 4.627     | 19.949      |
| AaveV3Ethereum_StkGHOActivation_20240119                                                                 | 1.115     | 23.461      |
| AaveV3Ethereum_TreasuryManagementGSMFundingRWAStrategyPreparationsPart2_20240209                         | 3.098     | 21.478      |
| AaveV3Ethereum_UpdateADIImplementationAndCCIPAdapters_20240313                                           | 3.553     | 21.023      |
| AaveV3Ethereum_UpdateStETHAndWETHRiskParamsOnAaveV3EthereumOptimismAndArbitrum_20240121                  | 3.905     | 20.671      |
| AaveV3Fantom                                                                                             | 0.045     | 24.531      |
| AaveV3FantomAssets                                                                                       | 0.045     | 24.531      |
| AaveV3FantomEModes                                                                                       | 0.045     | 24.531      |
| AaveV3GenericPatch_20240104                                                                              | 0.479     | 24.097      |
| AaveV3Gnosis                                                                                             | 0.045     | 24.531      |
| AaveV3GnosisAssets                                                                                       | 0.045     | 24.531      |
| AaveV3GnosisEModes                                                                                       | 0.045     | 24.531      |
| AaveV3Gnosis_Patch_20240104                                                                              | 0.479     | 24.097      |
| AaveV3Gnosis_StablecoinHarmonization_20240312                                                            | 3.571     | 21.005      |
| AaveV3Gnosis_StablecoinIRCurvesUpdates_20231221                                                          | 3.87      | 20.706      |
| AaveV3Gnosis_UpdateADIImplementationAndCCIPAdapters_20240313                                             | 0.588     | 23.988      |
| AaveV3Harmony                                                                                            | 0.045     | 24.531      |
| AaveV3HarmonyAssets                                                                                      | 0.045     | 24.531      |
| AaveV3HarmonyEModes                                                                                      | 0.045     | 24.531      |
| AaveV3Metis                                                                                              | 0.045     | 24.531      |
| AaveV3MetisAssets                                                                                        | 0.045     | 24.531      |
| AaveV3MetisEModes                                                                                        | 0.045     | 24.531      |
| AaveV3Metis_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                          | 3.37      | 21.206      |
| AaveV3Metis_StablecoinHarmonization_20240312                                                             | 3.397     | 21.179      |
| AaveV3Metis_StablecoinIRCurvesUpdates_20231221                                                           | 3.869     | 20.707      |
| AaveV3Metis_UpdateADIImplementationAndCCIPAdapters_20240313                                              | 0.588     | 23.988      |
| AaveV3Optimism                                                                                           | 0.045     | 24.531      |
| AaveV3OptimismAssets                                                                                     | 0.045     | 24.531      |
| AaveV3OptimismEModes                                                                                     | 0.045     | 24.531      |
| AaveV3Optimism_AddFlashborrowers_20240306                                                                | 0.25      | 24.326      |
| AaveV3Optimism_AssignEmissionAdminEthereumArbitrumAndOptimism_20240229                                   | 0.31      | 24.266      |
| AaveV3Optimism_GauntletRecommendationForMAIMIMATICDeprecationPhase2_20240122                             | 3.375     | 21.201      |
| AaveV3Optimism_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                       | 3.362     | 21.214      |
| AaveV3Optimism_Patch_20240104                                                                            | 0.479     | 24.097      |
| AaveV3Optimism_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206                 | 0.212     | 24.364      |
| AaveV3Optimism_StablecoinHarmonization_20240312                                                          | 3.749     | 20.827      |
| AaveV3Optimism_StablecoinIRCurvesUpdates_20231221                                                        | 4.878     | 19.698      |
| AaveV3Optimism_UpdateADIImplementationAndCCIPAdapters_20240313                                           | 0.588     | 23.988      |
| AaveV3Optimism_UpdateStETHAndWETHRiskParamsOnAaveV3EthereumOptimismAndArbitrum_20240121                  | 3.892     | 20.684      |
| AaveV3Optimism_UpdateWETHIROnV3ArbitrumAndOptimism_20240216                                              | 3.609     | 20.967      |
| AaveV3Polygon                                                                                            | 0.045     | 24.531      |
| AaveV3PolygonAssets                                                                                      | 0.045     | 24.531      |
| AaveV3PolygonEModes                                                                                      | 0.045     | 24.531      |
| AaveV3Polygon_FreezeAndSetLTVTo0ForDPIBALCRVAndSUSHIOnAaveV3Polygon20240119_20240130                     | 4.355     | 20.221      |
| AaveV3Polygon_FundingUpdate_20240224                                                                     | 2.902     | 21.674      |
| AaveV3Polygon_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115                                        | 3.361     | 21.215      |
| AaveV3Polygon_MaticXSupplyCapIncreaseInPolygonV3_20240206                                                | 3.294     | 21.282      |
| AaveV3Polygon_Patch_20240104                                                                             | 0.479     | 24.097      |
| AaveV3Polygon_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206                  | 0.212     | 24.364      |
| AaveV3Polygon_StablecoinHarmonization_20240312                                                           | 3.975     | 20.601      |
| AaveV3Polygon_StablecoinIRCurvesUpdates_20231221                                                         | 4.375     | 20.201      |
| AaveV3Polygon_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1_20231229                          | 3.418     | 21.158      |
| AaveV3Polygon_UpdateADIImplementationAndCCIPAdapters_20240313                                            | 3.292     | 21.284      |
| AaveV3Scroll                                                                                             | 0.045     | 24.531      |
| AaveV3ScrollAssets                                                                                       | 0.045     | 24.531      |
| AaveV3ScrollEModes                                                                                       | 0.045     | 24.531      |
| AaveV3Scroll_AaveV3ScrollActivation_20240122                                                             | 6.6       | 17.976      |
| AaveV3Scroll_UpdateADIImplementationAndCCIPAdapters_20240313                                             | 0.588     | 23.988      |
| AaveV3Scroll_V3PeripheryMaintenance_20240314                                                             | 0.25      | 24.326      |
| Address                                                                                                  | 0.045     | 24.531      |
| BaseCCCImplementationUpdatePayload                                                                       | 0.588     | 23.988      |
| ChainHelpers                                                                                             | 0.045     | 24.531      |
| ChainIds                                                                                                 | 0.045     | 24.531      |
| ConfiguratorInputTypes                                                                                   | 0.045     | 24.531      |
| Create2Utils                                                                                             | 0.123     | 24.453      |
| DataTypes                                                                                                | 0.045     | 24.531      |
| ERC1967Proxy                                                                                             | 0.136     | 24.44       |
| EngineFlags                                                                                              | 0.045     | 24.531      |
| EnumerableSet                                                                                            | 0.045     | 24.531      |
| EnvelopeUtils                                                                                            | 0.045     | 24.531      |
| Errors                                                                                                   | 4.673     | 19.903      |
| GhoInterestRateStrategy                                                                                  | 0.671     | 23.905      |
| Gho_GHOStabilityModule_20240119                                                                          | 4.494     | 20.082      |
| GovHelpers                                                                                               | 0.045     | 24.531      |
| GovV3Helpers                                                                                             | 2.581     | 21.995      |
| GovV3StorageHelpers                                                                                      | 0.045     | 24.531      |
| GovernanceV3Arbitrum                                                                                     | 0.045     | 24.531      |
| GovernanceV3Avalanche                                                                                    | 0.045     | 24.531      |
| GovernanceV3BNB                                                                                          | 0.045     | 24.531      |
| GovernanceV3Base                                                                                         | 0.045     | 24.531      |
| GovernanceV3Ethereum                                                                                     | 0.045     | 24.531      |
| GovernanceV3Gnosis                                                                                       | 0.045     | 24.531      |
| GovernanceV3Metis                                                                                        | 0.045     | 24.531      |
| GovernanceV3Optimism                                                                                     | 0.045     | 24.531      |
| GovernanceV3Polygon                                                                                      | 0.045     | 24.531      |
| GovernanceV3PolygonZkEvm                                                                                 | 0.045     | 24.531      |
| GovernanceV3Scroll                                                                                       | 0.045     | 24.531      |
| IpfsUtils                                                                                                | 0.045     | 24.531      |
| MainnetPayload                                                                                           | 2.583     | 21.993      |
| MiscArbitrum                                                                                             | 0.045     | 24.531      |
| MiscAvalanche                                                                                            | 0.045     | 24.531      |
| MiscBNB                                                                                                  | 0.045     | 24.531      |
| MiscBase                                                                                                 | 0.045     | 24.531      |
| MiscEthereum                                                                                             | 0.045     | 24.531      |
| MiscGnosis                                                                                               | 0.045     | 24.531      |
| MiscMetis                                                                                                | 0.045     | 24.531      |
| MiscOptimism                                                                                             | 0.045     | 24.531      |
| MiscPolygon                                                                                              | 0.045     | 24.531      |
| MiscScroll                                                                                               | 0.045     | 24.531      |
| MockExecutor                                                                                             | 0.396     | 24.18       |
| OrbitProgramData                                                                                         | 0.488     | 24.088      |
| ParaswapClaim                                                                                            | 0.022     | 24.554      |
| ParaswapClaimer                                                                                          | 0.159     | 24.417      |
| Payloads                                                                                                 | 0.484     | 24.092      |
| PayloadsControllerUtils                                                                                  | 0.045     | 24.531      |
| PayloadsToDeploy                                                                                         | 0.045     | 24.531      |
| PolygonPayload                                                                                           | 1.593     | 22.983      |
| PoolAddresses                                                                                            | 0.316     | 24.26       |
| ProxyAdmin                                                                                               | 1.642     | 22.934      |
| ProxyHelpers                                                                                             | 0.045     | 24.531      |
| ReserveConfiguration                                                                                     | 0.13      | 24.446      |
| RewardsDataTypes                                                                                         | 0.045     | 24.531      |
| SafeERC20                                                                                                | 0.045     | 24.531      |
| StataPayloads                                                                                            | 0.045     | 24.531      |
| StorageHelpers                                                                                           | 0.045     | 24.531      |
| StorageSlot                                                                                              | 0.045     | 24.531      |
| TransactionUtils                                                                                         | 0.045     | 24.531      |
| TransparentUpgradeableProxy                                                                              | 2.04      | 22.536      |
| WadRayMath                                                                                               | 0.045     | 24.531      |
Test error :finnadie:
No files changed, compilation skipped
2024-03-25T15:14:08.877394Z ERROR sharedbackend: Failed to send/recv `basic` err=failed to get account for 0x953A573793604aF8d41F306FEb8274190dB4aE0e: Error during transport: Max retries exceeded address=0x953A573793604aF8d41F306FEb8274190dB4aE0e

Ran 2 tests for src/20240315_AaveV3Arbitrum_ARBRemoveIsolation/AaveV3Arbitrum_ARBRemoveIsolation_20240315.t.sol:AaveV3Arbitrum_ARBRemoveIsolation_20240315_Test
[FAIL. Reason: failed to get account for 0x953A573793604aF8d41F306FEb8274190dB4aE0e: Error during transport: Max retries exceeded] test_defaultProposalExecution() (gas: 1280644)
[PASS] test_removalFromIsolation() (gas: 169495)
Suite result: FAILED. 1 passed; 1 failed; 0 skipped; finished in 348.54s (412.36s CPU time)

Ran 1 test suite in 348.55s (348.54s CPU time): 1 tests passed, 1 failed, 0 skipped (2 total tests)

Failing tests:
Encountered 1 failing test in src/20240315_AaveV3Arbitrum_ARBRemoveIsolation/AaveV3Arbitrum_ARBRemoveIsolation_20240315.t.sol:AaveV3Arbitrum_ARBRemoveIsolation_20240315_Test
[FAIL. Reason: failed to get account for 0x953A573793604aF8d41F306FEb8274190dB4aE0e: Error during transport: Max retries exceeded] test_defaultProposalExecution() (gas: 1280644)

Encountered a total of 1 failing tests, 1 tests succeeded


With the support of the Risk Service providers, this proposal is to disable Isolation Mode and enable ARB to be used in combination with other assets as collateral.

## Specification:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Specification is completely arbitrary, not saying anything of what the proposal does

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.
I suppose that's a flaw in the initial proposal itself.

This has already been voted on though, should we change it only here or also in the forum?

@brotherlymite brotherlymite merged commit c5a7669 into bgd-labs:main Mar 25, 2024
@efecarranza efecarranza deleted the remove-arb-isolation branch July 31, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants