Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHO increase borrow rate - Review #48

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

marczeller
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 9, 2023

Foundry report

forge 0.2.0 (57180fc 2023-11-09T01:52:52.711349925Z)
Build log
Compiling 158 files with 0.8.19
Solc 0.8.19 finished in 80.33s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/aave-helpers/src/GovV3Helpers.sol:730:5:
    |
730 |     address votingPortal
    |     ^^^^^^^^^^^^^^^^^^^^

| Contract                                                    | Size (kB) | Margin (kB) |
|-------------------------------------------------------------|-----------|-------------|
| AaveGovernanceV2                                            | 0.086     | 24.49       |
| AaveV1Ethereum_FixedREPPriceFeed_20231031                   | 0.706     | 23.87       |
| AaveV2Avalanche                                             | 0.086     | 24.49       |
| AaveV2AvalancheAssets                                       | 0.086     | 24.49       |
| AaveV2Ethereum                                              | 0.086     | 24.49       |
| AaveV2EthereumAMM                                           | 0.086     | 24.49       |
| AaveV2EthereumAMMAssets                                     | 0.086     | 24.49       |
| AaveV2EthereumAssets                                        | 0.086     | 24.49       |
| AaveV2Ethereum_AaveV2EthereumLTReduction_20231030           | 3.023     | 21.553      |
| AaveV2Ethereum_Disable_Stable_Borrows_20231104              | 2.519     | 22.057      |
| AaveV2Polygon                                               | 0.086     | 24.49       |
| AaveV2PolygonAssets                                         | 0.086     | 24.49       |
| AaveV3Arbitrum                                              | 0.086     | 24.49       |
| AaveV3ArbitrumAssets                                        | 0.086     | 24.49       |
| AaveV3ArbitrumEModes                                        | 0.086     | 24.49       |
| AaveV3Arbitrum_Disable_Stable_Borrows_20231104              | 4.14      | 20.436      |
| AaveV3Avalanche                                             | 0.086     | 24.49       |
| AaveV3AvalancheAssets                                       | 0.086     | 24.49       |
| AaveV3AvalancheEModes                                       | 0.086     | 24.49       |
| AaveV3Avalanche_Disable_Stable_Borrows_20231104             | 3.471     | 21.105      |
| AaveV3Ethereum                                              | 0.086     | 24.49       |
| AaveV3EthereumAssets                                        | 0.086     | 24.49       |
| AaveV3EthereumEModes                                        | 0.086     | 24.49       |
| AaveV3Ethereum_ACIPhaseII_20231029                          | 0.682     | 23.894      |
| AaveV3Ethereum_ChaosLabsRiskManagementRenewal_20231101      | 1.014     | 23.562      |
| AaveV3Ethereum_GHOIncreaseBorrowRate_20231108               | 0.326     | 24.25       |
| AaveV3Ethereum_UpgradeAaveV3ETHPooolWETHParameters_20231031 | 3.671     | 20.905      |
| AaveV3Fantom                                                | 0.086     | 24.49       |
| AaveV3FantomAssets                                          | 0.086     | 24.49       |
| AaveV3FantomEModes                                          | 0.086     | 24.49       |
| AaveV3Gnosis                                                | 0.086     | 24.49       |
| AaveV3GnosisAssets                                          | 0.086     | 24.49       |
| AaveV3GnosisEModes                                          | 0.086     | 24.49       |
| AaveV3Gnosis_AaveV3GnosisActivation_20231026                | 8.802     | 15.774      |
| AaveV3Harmony                                               | 0.086     | 24.49       |
| AaveV3HarmonyAssets                                         | 0.086     | 24.49       |
| AaveV3HarmonyEModes                                         | 0.086     | 24.49       |
| AaveV3Optimism                                              | 0.086     | 24.49       |
| AaveV3OptimismAssets                                        | 0.086     | 24.49       |
| AaveV3OptimismEModes                                        | 0.086     | 24.49       |
| AaveV3Optimism_Disable_Stable_Borrows_20231104              | 3.851     | 20.725      |
| AaveV3Polygon                                               | 0.086     | 24.49       |
| AaveV3PolygonAssets                                         | 0.086     | 24.49       |
| AaveV3PolygonEModes                                         | 0.086     | 24.49       |
| AaveV3Polygon_Disable_Stable_Borrows_20231104               | 4.139     | 20.437      |
| Address                                                     | 0.086     | 24.49       |
| ChainHelpers                                                | 0.086     | 24.49       |
| ChainIds                                                    | 0.086     | 24.49       |
| ConfiguratorInputTypes                                      | 0.086     | 24.49       |
| Create2Utils                                                | 0.164     | 24.412      |
| DataTypes                                                   | 0.086     | 24.49       |
| EngineFlags                                                 | 0.086     | 24.49       |
| Errors                                                      | 4.714     | 19.862      |
| GovHelpers                                                  | 0.086     | 24.49       |
| GovV3Helpers                                                | 0.086     | 24.49       |
| GovV3StorageHelpers                                         | 0.086     | 24.49       |
| GovernanceV3Arbitrum                                        | 0.086     | 24.49       |
| GovernanceV3Avalanche                                       | 0.086     | 24.49       |
| GovernanceV3BNB                                             | 0.086     | 24.49       |
| GovernanceV3Base                                            | 0.086     | 24.49       |
| GovernanceV3Ethereum                                        | 0.086     | 24.49       |
| GovernanceV3Gnosis                                          | 0.086     | 24.49       |
| GovernanceV3Metis                                           | 0.086     | 24.49       |
| GovernanceV3Optimism                                        | 0.086     | 24.49       |
| GovernanceV3Polygon                                         | 0.086     | 24.49       |
| IpfsUtils                                                   | 0.086     | 24.49       |
| MiscEthereum                                                | 0.086     | 24.49       |
| MockExecutor                                                | 0.437     | 24.139      |
| PayloadsControllerUtils                                     | 0.086     | 24.49       |
| ProxyHelpers                                                | 0.086     | 24.49       |
| ReserveConfiguration                                        | 0.171     | 24.405      |
| SafeERC20                                                   | 0.086     | 24.49       |
| StdStyle                                                    | 0.086     | 24.49       |
| StorageHelpers                                              | 0.086     | 24.49       |
| WadRayMath                                                  | 0.086     | 24.49       |
| console                                                     | 0.086     | 24.49       |
| console2                                                    | 0.086     | 24.49       |
| safeconsole                                                 | 0.086     | 24.49       |
| stdError                                                    | 0.591     | 23.985      |
| stdJson                                                     | 0.086     | 24.49       |
| stdMath                                                     | 0.086     | 24.49       |
| stdStorage                                                  | 0.086     | 24.49       |
| stdStorageSafe                                              | 0.086     | 24.49       |
Test success 🌈
No files changed, compilation skipped

Running 1 test for src/20231108_AaveV3Ethereum_GHOIncreaseBorrowRate/AaveV3Ethereum_GHOIncreaseBorrowRate_20231108.t.sol:AaveV3Ethereum_GHOIncreaseBorrowRate_20231108_Test
[PASS] test_defaultProposalExecution() (gas: 184529984)
Logs:
  0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
  0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0
  0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599
  0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48
  0x6B175474E89094C44Da98b954EedeAC495271d0F
  0x514910771AF9Ca656af840dff83E8264EcF986CA
  0xBe9895146f7AF43049ca1c1AE358B0541Ea49704
  0xdAC17F958D2ee523a2206206994597C13D831ec7
  0xae78736Cd615f374D3085123A210448E74Fc6393
  0x5f98805A4E8be255a32880FDeC7F6728C6568bA0
  0xD533a949740bb3306d119CC777fa900bA034cd52
  0x9f8F72aA9304c8B593d555F12eF6589cC3A579A2
  0xC011a73ee8576Fb46F5E1c5751cA3B9Fe0af2a6F
  0xba100000625a3754423978a60c9317c58a424e3D
  0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984
  0x5A98FcBEA516Cf06857215779Fd812CA3beF1B32
  0xC18360217D8F7Ab5e7c516566761Ea12Ce7F9D72
  0x111111111117dC0aa78b770fA6A738034120C302
  0x853d955aCEf822Db058eb8505911ED77F175b99e
  0xD33526068D116cE69F19A9ee46F0bd304F21A51f
  0xAf5191B0De278C7286d6C7CC6ab6BB8A73bA2Cd6
  0xdeFA4e8a7bcBA345F687a2f1456F5Edd9CE97202
  E2E: Collateral WETH, TestAsset WETH
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: WETH, Amount: 53030424350134067
  WITHDRAW: WETH, Amount: 26515212175067033
  WITHDRAW: WETH, Amount: 26515212175067034
  BORROW: WETH, Amount 53030424350134067, Stable: false
  REPAY: WETH, Amount: 53030424350134067
  E2E: Collateral WETH, TestAsset wstETH
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: wstETH, Amount: 46281912158688602
  WITHDRAW: wstETH, Amount: 23140956079344301
  WITHDRAW: wstETH, Amount: 23140956079344300
  BORROW: wstETH, Amount 46281912158688602, Stable: false
  REPAY: wstETH, Amount: 46281912158688602
  E2E: Collateral WETH, TestAsset WBTC
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: WBTC, Amount: 282650
  WITHDRAW: WBTC, Amount: 141325
  WITHDRAW: WBTC, Amount: 141324
  BORROW: WBTC, Amount 282650, Stable: false
  REPAY: WBTC, Amount: 282650
  E2E: Collateral WETH, TestAsset USDC
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: USDC, Amount: 100007013
  WITHDRAW: USDC, Amount: 50003506
  WITHDRAW: USDC, Amount: 50003507
  BORROW: USDC, Amount 100007013, Stable: false
  REPAY: USDC, Amount: 100007013
  E2E: Collateral WETH, TestAsset DAI
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: DAI, Amount: 100009329870383608086
  WITHDRAW: DAI, Amount: 50004664935191804043
  WITHDRAW: DAI, Amount: 50004664935191804042
  BORROW: DAI, Amount 100009329870383608086, Stable: false
  REPAY: DAI, Amount: 100009329870383608086
  E2E: Collateral WETH, TestAsset LINK
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: LINK, Amount: 7272409412901166156
  WITHDRAW: LINK, Amount: 3636204706450583078
  WITHDRAW: LINK, Amount: 3636204706450583077
  BORROW: LINK, Amount 7272409412901166156, Stable: false
  REPAY: LINK, Amount: 7272409412901166156
  E2E: Collateral WETH, TestAsset AAVE
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: AAVE, Amount: 1028464113113298683
  WITHDRAW: AAVE, Amount: 514232056556649341
  WITHDRAW: AAVE, Amount: 514232056556649342
  E2E: Collateral WETH, TestAsset cbETH
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: cbETH, Amount: 50365003644495042
  WITHDRAW: cbETH, Amount: 25182501822247521
  WITHDRAW: cbETH, Amount: 25182501822247522
  BORROW: cbETH, Amount 50365003644495042, Stable: false
  REPAY: cbETH, Amount: 50365003644495042
  E2E: Collateral WETH, TestAsset USDT
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: USDT, Amount: 99982947
  WITHDRAW: USDT, Amount: 49991473
  WITHDRAW: USDT, Amount: 49991475
  BORROW: USDT, Amount 99982947, Stable: false
  REPAY: USDT, Amount: 99982947
  E2E: Collateral WETH, TestAsset rETH
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: rETH, Amount: 48710995635891337
  WITHDRAW: rETH, Amount: 24355497817945668
  WITHDRAW: rETH, Amount: 24355497817945669
  BORROW: rETH, Amount 48710995635891337, Stable: false
  REPAY: rETH, Amount: 48710995635891337
  E2E: Collateral WETH, TestAsset LUSD
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: LUSD, Amount: 100281537407826350243
  WITHDRAW: LUSD, Amount: 50140768703913175121
  WITHDRAW: LUSD, Amount: 50140768703913175123
  BORROW: LUSD, Amount 100281537407826350243, Stable: false
  REPAY: LUSD, Amount: 100281537407826350243
  E2E: Collateral WETH, TestAsset CRV
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: CRV, Amount: 175229857765924451399
  WITHDRAW: CRV, Amount: 87614928882962225699
  WITHDRAW: CRV, Amount: 87614928882962225700
  E2E: Collateral WETH, TestAsset MKR
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: MKR, Amount: 76270931420739213
  WITHDRAW: MKR, Amount: 38135465710369606
  WITHDRAW: MKR, Amount: 38135465710369606
  BORROW: MKR, Amount 76270931420739213, Stable: false
  REPAY: MKR, Amount: 76270931420739213
  E2E: Collateral WETH, TestAsset SNX
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: SNX, Amount: 39436997424764068162
  WITHDRAW: SNX, Amount: 19718498712382034081
  WITHDRAW: SNX, Amount: 19718498712382034080
  BORROW: SNX, Amount 39436997424764068162, Stable: false
  REPAY: SNX, Amount: 39436997424764068162
  E2E: Collateral WETH, TestAsset BAL
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: BAL, Amount: 26881720430107526881
  WITHDRAW: BAL, Amount: 13440860215053763440
  WITHDRAW: BAL, Amount: 13440860215053763442
  BORROW: BAL, Amount 26881720430107526881, Stable: false
  REPAY: BAL, Amount: 26881720430107526881
  E2E: Collateral WETH, TestAsset UNI
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: UNI, Amount: 19498979303504531856
  WITHDRAW: UNI, Amount: 9749489651752265928
  WITHDRAW: UNI, Amount: 9749489651752265928
  BORROW: UNI, Amount 19498979303504531856, Stable: false
  REPAY: UNI, Amount: 19498979303504531856
  E2E: Collateral WETH, TestAsset LDO
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: LDO, Amount: 51278253272758879710
  WITHDRAW: LDO, Amount: 25639126636379439855
  WITHDRAW: LDO, Amount: 25639126636379439855
  BORROW: LDO, Amount 51278253272758879710, Stable: false
  REPAY: LDO, Amount: 51278253272758879710
  E2E: Collateral WETH, TestAsset ENS
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: ENS, Amount: 11941460586243868013
  WITHDRAW: ENS, Amount: 5970730293121934006
  WITHDRAW: ENS, Amount: 5970730293121934006
  BORROW: ENS, Amount 11941460586243868013, Stable: false
  REPAY: ENS, Amount: 11941460586243868013
  E2E: Collateral WETH, TestAsset 1INCH
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: 1INCH, Amount: 276778300581234431220
  WITHDRAW: 1INCH, Amount: 138389150290617215610
  WITHDRAW: 1INCH, Amount: 138389150290617215610
  BORROW: 1INCH, Amount 276778300581234431220, Stable: false
  REPAY: 1INCH, Amount: 276778300581234431220
  E2E: Collateral WETH, TestAsset FRAX
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: FRAX, Amount: 100038485805874377931
  WITHDRAW: FRAX, Amount: 50019242902937188965
  WITHDRAW: FRAX, Amount: 50019242902937188967
  BORROW: FRAX, Amount 100038485805874377931, Stable: false
  REPAY: FRAX, Amount: 100038485805874377931
  E2E: Collateral WETH, TestAsset GHO
  SUPPLY: WETH, Amount: 5303042435013406799
  BORROW: GHO, Amount 100000000000000000000, Stable: false
  REPAY: GHO, Amount: 100000000000000000000
  E2E: Collateral WETH, TestAsset RPL
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: RPL, Amount: 3796148978826529226
  WITHDRAW: RPL, Amount: 1898074489413264613
  WITHDRAW: RPL, Amount: 1898074489413264614
  BORROW: RPL, Amount 3796148978826529226, Stable: false
  REPAY: RPL, Amount: 3796148978826529226
  E2E: Collateral WETH, TestAsset sDAI
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: sDAI, Amount: 95978184849626610788
  WITHDRAW: sDAI, Amount: 47989092424813305394
  WITHDRAW: sDAI, Amount: 47989092424813305394
  E2E: Collateral WETH, TestAsset STG
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: STG, Amount: 178306563723155166740
  WITHDRAW: STG, Amount: 89153281861577583370
  WITHDRAW: STG, Amount: 89153281861577583370
  BORROW: STG, Amount 178306563723155166740, Stable: false
  REPAY: STG, Amount: 178306563723155166740
  E2E: Collateral WETH, TestAsset KNC
  SUPPLY: WETH, Amount: 5303042435013406799
  SUPPLY: KNC, Amount: 120512004893751494725
  WITHDRAW: KNC, Amount: 60256002446875747362
  WITHDRAW: KNC, Amount: 60256002446875747362
  BORROW: KNC, Amount 120512004893751494725, Stable: false
  REPAY: KNC, Amount: 120512004893751494725

Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 27.62s
 
Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests)

@sakulstra sakulstra merged commit 72cad7a into bgd-labs:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants