Fix rate limiting header #5
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-chaz
reviewed
Oct 15, 2021
| @@ -83,7 +83,7 @@ class Request { | |||
|
|
|||
| // If the API limit has been reached | |||
| if (res.statusCode === 429) { | |||
| const timeToWait = res.headers['x-retry-after']; | |||
| const timeToWait = res.headers['X-Rate-Limit-Time-Reset-Ms']; | |||
There was a problem hiding this comment.
resource for future devs: https://developer.bigcommerce.com/api-docs/getting-started/best-practices#api-rate-limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the rate limiting header used to determine how much time remains in the current rate limiting window, which is useful for understanding how long you must wait before resuming requests. This was using the the wrong header name.
@bigcommerce/api-client-developers