Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back button logic #81

Closed
nostrbuddha opened this issue Nov 27, 2024 · 4 comments
Closed

Back button logic #81

nostrbuddha opened this issue Nov 27, 2024 · 4 comments
Assignees
@nostrbuddha
Labels
UI
Milestone
MVP (version 0.1.0)

Comments

@nostrbuddha
Copy link
Contributor

Generalise back button logic in Topbar component, so it works smooth across android/iOS, across RootNav and TabNav
@rodvar
Copy link
Collaborator

rodvar commented Nov 27, 2024

also swipe left-to-right "back gesture" is not working on iOS (the android one: right-to-left does on Android).

@rodvar rodvar added the UI label Nov 28, 2024
@nostrbuddha nostrbuddha mentioned this issue Nov 29, 2024
Merged
@nostrbuddha
Copy link
Contributor Author

Jetpack compose doesn't seems to support the "back gesture" in iOS yet. It's not documented in their official documentation.

But I am inferring this from this discussion @ adrielcafe/voyager#144, where people have created custom solutions to accomplish this.

For us, I created Gesture handler, look for horizontal drag and initiate nav.pop. Made this logic to work only in iOS. So it's working (PR: #84)
But it doesn't show previous screen preview while transitioning.

Voyager folks implemented that as well. Not voyager's official solution, but people in that issue added a gist.
Understanding that logic and implementing it here will take a while.

Shall I get back to this later, once the other UI flows/issues are done?

@rodvar
Copy link
Collaborator

rodvar commented Nov 29, 2024

Jetpack compose doesn't seems to support the "back gesture" in iOS yet. It's not documented in their official documentation.

But I am inferring this from this discussion @ adrielcafe/voyager#144, where people have created custom solutions to accomplish this.

For us, I created Gesture handler, look for horizontal drag and initiate nav.pop. Made this logic to work only in iOS. So it's working (PR: #84) But it doesn't show previous screen preview while transitioning.

Voyager folks implemented that as well. Not voyager's official solution, but people in that issue added a gist. Understanding that logic and implementing it here will take a while.

Shall I get back to this later, once the other UI flows/issues are done?

great work buddha, absolutely let's park that for now and come back to it when we have the MVP basics done 💪

@rodvar rodvar mentioned this issue Nov 29, 2024
Merged
rodvar pushed a commit that referenced this issue Dec 1, 2024
@nostrbuddha
UI Fixes #79, #81: Back button, Small screen layouts (#84)
5af44e6 
* - Nav: Back button generalization

* - layout improvements: consistent, better padding across screens; tested in small screen devices; BisqTextField improvements

* Swipe back navigation for IOS

* Fix: Back button whilte screen issue; isIOS() moved to presenter
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Dec 9, 2024
@rodvar rodvar changed the title UI: Back button logic Back button logic Dec 18, 2024
@rodvar
Copy link
Collaborator

rodvar commented Dec 19, 2024

closing this one , newer issues will be created when needed

@rodvar rodvar closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nostrbuddha nostrbuddha

Labels
UI
Projects
None yet
Milestone
MVP (version 0.1.0)
Development

No branches or pull requests
2 participants
@rodvar @nostrbuddha