UI Fixes #79, #81: Back button, Small screen layouts #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nostrbuddha
changed the title
…sted in small screen devices; BisqTextField improvements
|
rebased branch against main |
rodvar
requested changes
Nov 29, 2024
There was a problem hiding this comment.
UI wise looks great - functionality wise needs more work:
- bug: (100% reproducible) after the back arrow has been rendered at least once, clicking on the title will blank all the UI (see screenshot)
- bug: sometimes the back arrow won't show up (I could only repro this once, could't figure out the steps yet)
I've also put some comments on the code.
iPhone swipe works!
...nMain/kotlin/network/bisq/mobile/presentation/ui/components/SwipeBackIOSNavigationHandler.kt
Show resolved
Hide resolved
...ion/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/molecules/TopBar.kt
Show resolved
Hide resolved
|
Missed that back button white screen issues! Tried replicating back button not appearing. Couldn't make it happen! Can you please try this again and give me any hints? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixes for #81 (temporary patch) and #79
Summarizing here. Added more in those specific issues: