UI: Various improvements and fixes #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handles lengthy names - Handles range prices for currencies with many digits - Star rating composable
…cyCard - Handle lengthy currency names (bisq-network#121); DropDown component
rodvar
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Excellent Job @nostrbuddha
Only minor code comments to consider for next PR.
For the payment accounts some UI stuff could be improved (floating combo box positioning for example) but we can do that later on the polishing stage. Merging now :D
shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/BasePresenter.kt
Show resolved
Hide resolved
.../src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/SegmentButton.kt
Show resolved
Hide resolved
IDE warning related to one of my comments above @nostrbuddha |
Thanks. Will take care of the warnings in future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalStrings.currentaccessible asstringsfrom all presenters that inherit from BasePresenter