Add trade process domain #153

HenrikJannsen · 2025-01-12T17:21:40Z

No description provided.

…s created in presenterScope are cancelled when view gets detached

We should set that flag from the run configuration, but not sure how that works in Android (in Bisq 2 we pass it as JVM argument). Also reduce the devModeDelayInMs which is just to mimic a delay at clearnet.

rodvar · 2025-01-13T02:41:07Z

Hey Henrik! Thanks for this huge contrib. Just a heads up, I cannot test it (details below). In the meantime I'll start code-reviewing

Android Node

It won't build error is

Projects/bisq-mobile/androidNode/src/androidMain/kotlin/network/bisq/mobile/android/node/presentation/NodeSplashPresenter.kt:17:100 No value passed for parameter 'settingsServiceFacade'.

But a repository is passed instead?

Clients

I can't do anything because it seems the profile functionality got broken? Every trading functionality of even trying to see the profile clicking in the avatar gives crashes like this

Caused by: kotlinx.serialization.MissingFieldException: Fields [payloadEncoded, challengeEncoded, solutionEncoded] are required for type with serial name 'network.bisq.mobile.domain.data.replicated.security.pow.ProofOfWorkVO', but they were missing
    at 0   presentation                        0x10bf962cf        kfun:kotlin.Exception#<init>(kotlin.String?;kotlin.Throwable?){} + 143 (/opt/buildAgent/work/ed783494cd2364bc/kotlin/kotlin-native/runtime/src/main/kotlin/kotlin/Exceptions.kt:25:70)
    at 1   presentation                        0x10bf964ef        kfun:kotlin.RuntimeException#<init>(kotlin.String?;kotlin.Throwable?){} + 143 (/opt/buildAgent/work/ed783494cd2364bc/kotlin/kotlin-native/runtime/src/main/kotlin/kotlin/Exceptions.kt:36:70)
    at 2   presentation                        0x10bf9686f        kfun:kotlin.IllegalArgumentException#<init>(kotlin.String?;kotlin.Throwable?){} + 143 (/opt/buildAgent/work/ed783494cd2364bc/kotlin/kotlin-native/runtime/src/main/kotlin/kotlin/Exceptions.kt:61:70)

HenrikJannsen · 2025-01-13T05:57:10Z

Projects/bisq-mobile/androidNode/src/androidMain/kotlin/network/bisq/mobile/android/node/presentation/NodeSplashPresenter.kt:17:100 No value passed for parameter 'settingsServiceFacade'.

Ups was a last minute change yesterday. Fixed with recent commit.

I can't do anything because it seems the profile functionality got broken? Every trading functionality of even trying to see the profile clicking in the avatar gives crashes like this
Caused by: kotlinx.serialization.MissingFieldException: Fields [payloadEncoded, challengeEncoded, solutionEncoded] are required for type with serial name 'network.bisq.mobile.domain.data.replicated.security.pow.ProofOfWorkVO', but they were missing

Be sure to have both mobile and backend on latest verison, clean and build all and publish all. Maybe restart Fleet. I had some issues in Android Studio when doing bigger changes.

./gradlew clean build --refresh-dependencies might help as well.

HenrikJannsen · 2025-01-13T11:33:17Z

I am adding commits with refactoring and readme updates. Some areas are work in progress... those changes are pure refactorings, so no need to review those in depth. Once I am complete with that I will post it, but no need to block review or merge.

rodvar · 2025-01-13T23:56:49Z

First tests on Android Node

can take sell btc offer, all the process works as expected :D
can take buy btc offer, all the process works as expected :D
close trade -> crashes UI, node stops sync correctly only way to fix it is to force stop the app through system settings (commited a fix @HenrikJannsen please review)
"I received btc" button crashes the UI as well if the user doesn't input the btc proof, the code expects ui to force user to input proof, I'll do a crash avoid fix for now

There is sometimes a random error UI crash (UI turns completely blank) , not sure if its related but I found this exception on the logs. IT's not always reproducible, will keep trying to repro

Build configuration failed!
                                                                                                   java.lang.IllegalArgumentException: Must pass in a valid surface control if only instrument surface; 
                                                                                                   	at com.android.internal.jank.InteractionJankMonitor$Configuration.validate(InteractionJankMonitor.java:1259)
                                                                                                   	at com.android.internal.jank.InteractionJankMonitor$Configuration.<init>(InteractionJankMonitor.java:1217)
                                                                                                   	at com.android.internal.jank.InteractionJankMonitor$Configuration.<init>(Unknown Source:0)
                                                                                                   	at com.android.internal.jank.InteractionJankMonitor$Configuration$Builder.build(InteractionJankMonitor.java:1197)
                                                                                                   	at com.android.internal.jank.InteractionJankMonitor.begin(InteractionJankMonitor.java:611)
                                                                                                   	at android.view.inputmethod.ImeTracker$ImeJankTracker.onRequestAnimation(ImeTracker.java:717)
                                                                                                   	at android.view.InsetsController$InternalAnimationControlListener$2.onAnimationStart(InsetsController.java:448)
                                                                                                   	at android.animation.Animator$AnimatorListener.onAnimationStart(Animator.java:695)
                                                                                                   	at android.animation.Animator$AnimatorCaller$$ExternalSyntheticLambda0.call(Unknown Source:4)
                                                                                                   	at android.animation.Animator.callOnList(Animator.java:669)
                                                                                                   	at android.animation.Animator.notifyListeners(Animator.java:608)
                                                                                                   	at android.animation.Animator.notifyStartListeners(Animator.java:625)
                                                                                                   	at android.animation.ValueAnimator.startAnimation(ValueAnimator.java:1334)
                                                                                                   	at android.animation.ValueAnimator.start(ValueAnimator.java:1149)
                                                                                                   	at android.animation.ValueAnimator.start(ValueAnimator.java:1173)
                                                                                                   	at android.view.InsetsController$InternalAnimationControlListener.onReady(InsetsController.java:470)
                                                                                                   	at android.view.InsetsAnimationThreadControlRunner.lambda$new$0(InsetsAnimationThreadControlRunner.java:129)
                                                                                                   	at android.view.InsetsAnimationThreadControlRunner.$r8$lambda$3zGKYd3XPzPnvMO2hiF8a88M6T0(Unknown Source:0)
                                                                                                   	at android.view.InsetsAnimationThreadControlRunner$$ExternalSyntheticLambda2.run(Unknown Source:6)
                                                                                                   	at android.os.Handler.handleCallback(Handler.java:958)
                                                                                                   	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                   	at android.os.Looper.loopOnce(Looper.java:205)
                                                                                                   	at android.os.Looper.loop(Looper.java:294)
                                                                                                   	at android.os.HandlerThread.run(HandlerThread.java:67)

rodvar · 2025-01-14T01:04:29Z

Also getting this when closing a transaction

Request transaction from https://mempool.emzy.de failed with java.util.concurrent.CompletionException: java.lang.RuntimeException: java.io.IOException: Request to https://mempool.bisq.services/api/tx/sdffsd failed with error: Invalid hex string 2025-01-14 11:57:42.312 14354-14505 System.out network.bisq.mobile.node.debug I

rodvar · 2025-01-14T05:25:18Z

finally figured it out, no more white screens when closing the trade workflow

rodvar · 2025-01-14T05:55:21Z

looks like the trade flow presenter calls go back 4 times simultaneously when the trade is completed

52.075  22394-22394 TradeFlowPresenter      network.bisq.mobile.client.debug     I  goBack default implementation
52.076  22394-22394 TradeFlowPresenter      network.bisq.mobile.client.debug     I  goBack default implementation
52.077  22394-22394 TradeFlowPresenter      network.bisq.mobile.client.debug     I  goBack default implementation
52.077  22394-22394 TradeFlowPresenter      network.bisq.mobile.client.debug     I  goBack default implementation

…and not empty string if not set on LN.

rodvar

ACK

Tested and working on the 3 apps, some small issues were encountered and fixed along the way as described in GH logs in this branch.

Awesome work Henrik, excited for the next ones 🎉

androidClient/build.gradle.kts

rodvar · 2025-01-13T04:47:20Z

...Main/kotlin/network/bisq/mobile/android/node/service/mediation/NodeMediationServiceFacade.kt

+            val contract: BisqEasyContract = Mappings.BisqEasyContractMapping.toBisq2Model(value.bisqEasyTradeModel.contract)
+            mediationRequestService.requestMediation(channel, contract)
+        }
+        return Result.success(Unit)


add error handling(try/catch) ?

Mediation is WIP

...ndroidMain/kotlin/network/bisq/mobile/android/node/service/offers/NodeOffersServiceFacade.kt

rodvar · 2025-01-13T04:50:35Z

iosClient/Podfile.lock

@@ -18,4 +18,4 @@ SPEC CHECKSUMS:

 PODFILE CHECKSUM: 431d52ef58584308462794999ebead56142b0160

-COCOAPODS: 1.16.2
+COCOAPODS: 1.15.2


is this downgrade needed?

No, was uninteded from merge

iosClient/iosClient.xcodeproj/project.pbxproj

shared/domain/src/commonMain/kotlin/network/bisq/mobile/domain/data/model/Settings.kt

...sq/mobile/domain/data/replicated/chat/bisq_easy/open_trades/BisqEasyOpenTradeChannelModel.kt

...omain/src/commonMain/kotlin/network/bisq/mobile/domain/service/offers/OffersServiceFacade.kt

shared/domain/src/commonMain/kotlin/network/bisq/mobile/domain/utils/ExceptionUtils.kt

rodvar · 2025-01-15T03:17:05Z

shared/domain/src/commonMain/kotlin/network/bisq/mobile/domain/utils/ExceptionUtils.kt

+    fun Throwable.getRootCause(): Throwable {
+        var rootCause: Throwable = this
+        while (rootCause.cause != null && rootCause.cause != rootCause) {
+            rootCause = rootCause.cause!!


rootCause.cause?.let { rootCause = it } to avoid !! usage

rodvar · 2025-01-15T03:23:28Z

Implementation for #95 #96 #98 & #54 (Facade with jars usages for androidNode and ws gateway for clients)

HenrikJannsen added 16 commits January 12, 2025 16:10

Refactoring: Move replicated package into data package

54b50aa

Refactoring: Rename offer to offerbook. Move create_offer one level up

d9abff1

Refactoring: Move offerbook specific components to offerbook package

831ee12

Refactoring: Rename classes and files

445956d

Refactoring: Move take_offer package one level up

b022390

Refactoring: Rename classes and files

4ace971

Refactoring: Rename Routes, rearrange to group by domain

dc6ff10

Cleanup: Remove demo test classes

1bce3ed

Cleanup: Remove Greeting demo classes

02db6f9

Add trade process domain

7bd2d88

Add presenterScope.cancel() call at detachView to ensure that job…

a3df324

…s created in presenterScope are cancelled when view gets detached

Set devMode to true. For production we need to revert that.

e2f0d7f

We should set that flag from the run configuration, but not sure how that works in Android (in Bisq 2 we pass it as JVM argument). Also reduce the devModeDelayInMs which is just to mimic a delay at clearnet.

Fix build issues as localProperties["KEYSTORE_PATH"] is null

8fa79d7

Fix bug with delete offer at client

f7e82db

Fix missing reset of selectedTrade

c88bfe5

request settings in splash controller

0149222

rodvar self-assigned this Jan 13, 2025

Fix missing parameter

031e5c9

HenrikJannsen force-pushed the add-trade-process-domain branch from 028dc7e to 031e5c9 Compare January 13, 2025 06:01

HenrikJannsen added 2 commits January 13, 2025 15:52

Refactor: Rename and move classes

047ca27

Move readme and update

c9c45ef

Refactor dto and model classes

6407553

HenrikJannsen force-pushed the add-trade-process-domain branch from 3302191 to 6407553 Compare January 13, 2025 12:15

Add readme for websockets

eae85ab

rodvar force-pushed the add-trade-process-domain branch from defd43c to a80b06e Compare January 14, 2025 01:05

rodvar force-pushed the add-trade-process-domain branch from a80b06e to 9b8b966 Compare January 14, 2025 04:57

- fix UI crash on closing trade

77a3e56

- fix reject trade UI white screen of death

a30de03

rodvar force-pushed the add-trade-process-domain branch from 9b8b966 to a30de03 Compare January 14, 2025 05:33

rodvar and others added 2 commits January 14, 2025 17:14

- revert cocoapods downgrade (iOS crash on startup)

3f90745

Check if paymentProof is set only for mainchain. Ensure we sent null …

3032a61

…and not empty string if not set on LN.

rodvar approved these changes Jan 15, 2025

View reviewed changes

rodvar merged commit 640e676 into bisq-network:main Jan 15, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add trade process domain #153

Add trade process domain #153

HenrikJannsen commented Jan 12, 2025

rodvar commented Jan 13, 2025

HenrikJannsen commented Jan 13, 2025 •

edited

Loading

HenrikJannsen commented Jan 13, 2025

rodvar commented Jan 13, 2025

rodvar commented Jan 14, 2025

rodvar commented Jan 14, 2025

rodvar commented Jan 14, 2025

rodvar left a comment

rodvar Jan 13, 2025

HenrikJannsen Jan 15, 2025

rodvar Jan 13, 2025

HenrikJannsen Jan 15, 2025

rodvar Jan 15, 2025

rodvar commented Jan 15, 2025

Add trade process domain #153

Add trade process domain #153

Conversation

HenrikJannsen commented Jan 12, 2025

rodvar commented Jan 13, 2025

Android Node

Clients

HenrikJannsen commented Jan 13, 2025 • edited Loading

HenrikJannsen commented Jan 13, 2025

rodvar commented Jan 13, 2025

rodvar commented Jan 14, 2025

rodvar commented Jan 14, 2025

rodvar commented Jan 14, 2025

rodvar left a comment

Choose a reason for hiding this comment

rodvar Jan 13, 2025

Choose a reason for hiding this comment

HenrikJannsen Jan 15, 2025

Choose a reason for hiding this comment

rodvar Jan 13, 2025

Choose a reason for hiding this comment

HenrikJannsen Jan 15, 2025

Choose a reason for hiding this comment

rodvar Jan 15, 2025

Choose a reason for hiding this comment

rodvar commented Jan 15, 2025

HenrikJannsen commented Jan 13, 2025 •

edited

Loading