Code

V5 trade protocol#7105

Code

Draft

stejbac wants to merge 58 commits intobisq-network:masterbisq-network/bisq:masterfrom stejbac:v5-trade-protocolstejbac/bisq:v5-trade-protocolCopy head branch name to clipboard

+7,877-885

Commits

Commits on Jan 19, 2025

• Implement WarningTransactionFactory

  Show description for 2da4094
  

  alvasw

  authored and

  stejbac

  committed
  2da4094

  Copy full SHA for 2da4094

• Implement RedirectionTransactionFactory

  Show description for 997176d
  

  alvasw

  authored and

  stejbac

  committed
  997176d

  Copy full SHA for 997176d

• Implement ClaimTransactionFactory

  Show description for 30c3543
  

  alvasw

  authored and

  stejbac

  committed
  30c3543

  Copy full SHA for 30c3543

• Refactoring: Rename BuyerProtocol to BaseBuyerProtocol and SellerProtocol to BaseSellerProtocol

  Show description for 5c7e76b
  

  HenrikJannsen

  authored and

  stejbac

  committed
  5c7e76b

  Copy full SHA for 5c7e76b

• Refactoring: Add BuyerProtocol and SellerProtocol interfaces

  Show description for 4ae2996
  

  HenrikJannsen

  authored and

  stejbac

  committed
  4ae2996

  Copy full SHA for 4ae2996

• Refactoring: Use BuyerProtocol interfaces instead of BaseBuyerProtocol at client code

  Show description for 520691c
  

  HenrikJannsen

  authored and

  stejbac

  committed
  520691c

  Copy full SHA for 520691c

• Refactoring: Use SellerProtocol interfaces instead of BaseSellerProtocol at client code

  Show description for 75eae59
  

  HenrikJannsen

  authored and

  stejbac

  committed
  75eae59

  Copy full SHA for 75eae59

• Refactoring: Make BaseBuyerProtocol and BaseSellerProtocol package private and constructor protected

  Show description for c53ac0c
  

  HenrikJannsen

  authored and

  stejbac

  committed
  c53ac0c

  Copy full SHA for c53ac0c

• Refactoring: Move protocol interfaces one level up

  Show description for 098ff4f
  

  HenrikJannsen

  authored and

  stejbac

  committed
  098ff4f

  Copy full SHA for 098ff4f

• Refactoring: Remove comments

  Show description for 4dccec6
  

  HenrikJannsen

  authored and

  stejbac

  committed
  4dccec6

  Copy full SHA for 4dccec6

• Refactoring: Add methods to implementation classes even they have not custom code but only call super to make it more transparent which handler methods are in the protocol.

  Show description for 886113e
  

  HenrikJannsen

  authored and

  stejbac

  committed
  886113e

  Copy full SHA for 886113e

• Refactoring: Use getTradeProtocolVersion getter instead of public TRADE_PROTOCOL_VERSION field.

  Show description for 57b2c44
  

  HenrikJannsen

  authored and

  stejbac

  committed
  57b2c44

  Copy full SHA for 57b2c44

• Refactoring: Rename Protocol classes with _v4 postfix and move to protocol_v4 package

  

  HenrikJannsen

  authored and

  stejbac

  committed
  b5abcc0

  Copy full SHA for b5abcc0

• Use new protocol version after activation date

  Show description for 39f4522
  

  HenrikJannsen

  authored and

  stejbac

  committed
  39f4522

  Copy full SHA for 39f4522

• Add copies of protocol classes to bisq_v5 package. Those will serve as base for later implementing the new protocol.

  Show description for a3a0d10
  

  HenrikJannsen

  authored and

  stejbac

  committed
  a3a0d10

  Copy full SHA for a3a0d10

• Use new protocol classes if version 5 is activated

  Show description for ea11cab
  

  HenrikJannsen

  authored and

  stejbac

  committed
  ea11cab

  Copy full SHA for ea11cab

• Add new address entries

  Show description for 3f2c141
  

  HenrikJannsen

  authored and

  stejbac

  committed
  3f2c141

  Copy full SHA for 3f2c141

• Set v5 activation date in past for dev testing

  Show description for 28853b5
  

  HenrikJannsen

  authored and

  stejbac

  committed
  28853b5

  Copy full SHA for 28853b5

• Change method signatures

  Show description for b78b99a
  

  HenrikJannsen

  authored and

  stejbac

  committed
  b78b99a

  Copy full SHA for b78b99a

• Add util method for calculating fee rate which was used for the deposit tx.

  Show description for 4f2112d
  

  HenrikJannsen

  authored and

  stejbac

  committed
  4f2112d

  Copy full SHA for 4f2112d

• Add StagedPayoutTxParameters class which holds relevant protocol parameters

  Show description for a68baf6
  

  HenrikJannsen

  authored and

  stejbac

  committed
  a68baf6

  Copy full SHA for a68baf6

• Add fields for new protocol.

  Show description for aae9b6f
  

  HenrikJannsen

  authored and

  stejbac

  committed
  aae9b6f

  Copy full SHA for aae9b6f

• Add InputsForDepositTxResponse_v5 message

  Show description for 88db0e3
  

  HenrikJannsen

  authored and

  stejbac

  committed
  88db0e3

  Copy full SHA for 88db0e3

• Add new tasks for BuyerAsMakerProtocol_v5. We might generalize later to BuyerProtocol_v5, but for now we start with one variant (BuyerAsMakerProtocol_v5 and SellerAsTakerProtocol_v5)

  Show description for dec3318
  

  HenrikJannsen

  authored and

  stejbac

  committed
  dec3318

  Copy full SHA for dec3318

• Add new fields

  Show description for 894bc41
  

  HenrikJannsen

  authored and

  stejbac

  committed
  894bc41

  Copy full SHA for 894bc41

• Add InputsForDepositTxResponse_v5 message

  Show description for d003553
  

  HenrikJannsen

  authored and

  stejbac

  committed
  d003553

  Copy full SHA for d003553

• Add tasks for second phase

  Show description for 6a3dc7a
  

  HenrikJannsen

  authored and

  stejbac

  committed
  6a3dc7a

  Copy full SHA for 6a3dc7a

• Add BuyersRedirectSellerSignatureRequest

  Show description for 204c82e
  

  HenrikJannsen

  authored and

  stejbac

  committed
  204c82e

  Copy full SHA for 204c82e

• Add tasks for 3rd phase at buyer

  Show description for 1b97000
  

  HenrikJannsen

  authored and

  stejbac

  committed
  1b97000

  Copy full SHA for 1b97000

• Add BuyersRedirectSellerSignatureResponse

  Show description for 7e7fb7a
  

  HenrikJannsen

  authored and

  stejbac

  committed
  7e7fb7a

  Copy full SHA for 7e7fb7a

• Add tasks for 4th phase at seller

  Show description for ae4b07c
  

  HenrikJannsen

  authored and

  stejbac

  committed
  ae4b07c

  Copy full SHA for ae4b07c

• Comment out correctlySpends checks at claim and redirect txs.

  Show description for fdab428
  

  HenrikJannsen

  authored and

  stejbac

  committed
  fdab428

  Copy full SHA for fdab428

• Temp changes

  stejbac

  committed
  a688ece

  Copy full SHA for a688ece

• More temp changes

  stejbac

  committed
  d0d3f7d

  Copy full SHA for d0d3f7d

• Fix the warning, redirect & claim txs

  stejbac

  committed
  eae996e

  Copy full SHA for eae996e

• More changes the get the trade start working

  Show description for 7ee5ee6
  stejbac

  committed
  7ee5ee6

  Copy full SHA for 7ee5ee6

• Fix warning/redirect/claim tx fee calculations

  Show description for c2cfebf
  stejbac

  committed
  c2cfebf

  Copy full SHA for c2cfebf

• Make further improvements to the redirect tx fee precision

  Show description for d34e172
  stejbac

  committed
  d34e172

  Copy full SHA for d34e172

• Provide missing persistence for warning/redirect/claim txs

  Show description for 63e72c9
  stejbac

  committed
  63e72c9

  Copy full SHA for 63e72c9

• Fix UI+log errors/warnings in happy path of v5 trade protocol

  Show description for 2ed8dbd
  stejbac

  committed
  2ed8dbd

  Copy full SHA for 2ed8dbd

• Add some missing @nullable annotations

  Show description for 85abf3f
  stejbac

  committed
  85abf3f

  Copy full SHA for 85abf3f

• Ensure v5 staged txs are linked to trade in Transactions view

  Show description for 857b5e5
  stejbac

  committed
  857b5e5

  Copy full SHA for 857b5e5

• Use watched scripts to pick up broadcast of staged txs

  Show description for 8917717
  stejbac

  committed
  8917717

  Copy full SHA for 8917717

• Make Transactions view display correct types & amounts for staged txs

  Show description for 8476528
  stejbac

  committed
  8476528

  Copy full SHA for 8476528

• Use LowRSigningKey for warning, redirect & claim txs

  Show description for 67b7149
  stejbac

  committed
  67b7149

  Copy full SHA for 67b7149

• Add extra dispute states for v5 protocol

  Show description for 2fa9fd0
  stejbac

  committed
  2fa9fd0

  Copy full SHA for 2fa9fd0

• Add preliminary code to publish warning tx if mediation fails

  Show description for dbdf31f
  stejbac

  committed
  dbdf31f

  Copy full SHA for dbdf31f

• Add listener to pick up warning tx broadcast

  Show description for 33b2f4a
  stejbac

  committed
  33b2f4a

  Copy full SHA for 33b2f4a

• Pick up WARNING_SENT* dispute states in TradeStepView

  Show description for 9e100bd
  stejbac

  committed
  9e100bd

  Copy full SHA for 9e100bd

• Add downstream listeners to SetupWarningTxListener & rename

  Show description for 2599aeb
  stejbac

  committed
  2599aeb

  Copy full SHA for 2599aeb

• Make Transactions view tolerate missing tx witness data

  Show description for 8def265
  stejbac

  committed
  8def265

  Copy full SHA for 8def265

• Add code to redirect or claim after warning tx published

  Show description for b3c95a1
  stejbac

  committed
  b3c95a1

  Copy full SHA for b3c95a1

• Refactor replay detection logic in DisputeValidation

  Show description for 023d6e1
  stejbac

  committed
  023d6e1

  Copy full SHA for 023d6e1

• Tidy up DisputeView & fix broken comparator

  Show description for a348502
  stejbac

  committed
  a348502

  Copy full SHA for a348502

• Add warning & redirect txIds to dispute details & filter

  Show description for 9e6c9c0
  stejbac

  committed
  9e6c9c0

  Copy full SHA for 9e6c9c0

• Adapt refund agent tx chain validation to v5 protocol

  Show description for d97b63e
  stejbac

  committed
  d97b63e

  Copy full SHA for d97b63e

• Sanity check deposit tx output & receiver total before refunding

  Show description for 8b9ff7f
  stejbac

  committed
  8b9ff7f

  Copy full SHA for 8b9ff7f

• Restructure redeem script to reduce size of redirect & claim txs

  Show description for 8242a5c
  stejbac

  committed
  8242a5c

  Copy full SHA for 8242a5c