Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torrc overrides, support setting manual control port #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpiReCZ
Copy link

@SpiReCZ SpiReCZ commented Oct 15, 2022

Please enable Issues on this project. I know it's a fork, but it has a lot of changes and i guess it is the best version which deserves Issue tracking.

Fixes:

  • fix torrc overrides were not propagated (It was overwritten by defaults)
  • disable checking for port in stdout if it was already propagated outside (it was checking even after the port was set)

Features:

  • support to obtain control port that was set manually (required for my usage)

Other:

  • minor optimizations from IDE suggestions

…rt that was set manually, disable checking for port in stdout if it was already propagated outside, minor optimizations from IDE suggestions
@SpiReCZ
Copy link
Author

SpiReCZ commented Nov 1, 2022

@ripcurlx :) pretty please

@ripcurlx
Copy link

Unfortunately I only have limited time at hand to review and test changes in this repo. If @cd2357 is up for reviewing and approving it, I'm happy to merge it into our fork.

@theborakompanioni
Copy link

Very interested in this as well. Would be great to have @cd2357 👍

@theborakompanioni
Copy link

Is there any news related to this PR? Is there a possibility that this will be taken into account?

@theborakompanioni
Copy link

We are approaching the one year anniversary...any news on that?
Just fyi.. it would be totally okay to close the ticket if it will not be implemented.. just some infos would be great 🙏

@SpiReCZ
Copy link
Author

SpiReCZ commented Sep 25, 2023

We are approaching the one year anniversary...any news on that? Just fyi.. it would be totally okay to close the ticket if it will not be implemented.. just some infos would be great 🙏

I think this is a great example of open source hell 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants