Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-374: add generated test vector .csv files #1735

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

theStack
Copy link
Contributor

Even though the test vector generation script is available for BIP-374, I think it's generally a good practice to store the generated test vectors available in the BIP repository as well, so that everyone can verify that it yields deterministic results. In case refactoring / bugfix changes are needed in the test generation script in the future (e.g. #1729 for a recent example), one can check that the results are still equal.

Can be tested by:

$ cd ./bip-0374
$ sha256sum *.csv
$ ./gen_test_vectors.py
$ sha256sum *.csv

Both sha256sum commands should result in the same hash values.

@murchandamus
Copy link
Contributor

cc @andrewtoth

Copy link
Contributor

@andrewtoth andrewtoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a00064f

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept and tested ACK a00064f

@jonatack jonatack merged commit 4827bdf into bitcoin:master Dec 31, 2024
4 checks passed
@theStack theStack deleted the bip374-add_generated_test_vectors branch December 31, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants