BIP-374: add generated test vector .csv files #1735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the test vector generation script is available for BIP-374, I think it's generally a good practice to store the generated test vectors available in the BIP repository as well, so that everyone can verify that it yields deterministic results. In case refactoring / bugfix changes are needed in the test generation script in the future (e.g. #1729 for a recent example), one can check that the results are still equal.
Can be tested by:
Both
sha256sum
commands should result in the same hash values.