BIP372, BIP381: editorial fixups #1740
Conversation
There was a problem hiding this comment.
Considering this isn't just 1:1 spell-check fixes, it was merged a bit too quickly imo :(
LGTM other than the comment. Considering the weight of the words "may", "must", etc, in BIPS, it would be nice to have another set of eyes on changes like this before merging.
| of such outputs much allow hardware devices to understand the structure of such | ||
| P2C tweaks commit to external data, some of which may represent certain values | ||
| (like in some sidechains, single-use-seal applications like RGB, etc). Creation | ||
| of such outputs may allow hardware devices to understand the structure of such |
There was a problem hiding this comment.
This is a bit clunky before and after. I suspect "much allow" was supposed to be "must allow", which would be more readable as "would require".
There was a problem hiding this comment.
Thanks for taking a look.
@dr-orlovsky what is your intended meaning here?
There was a problem hiding this comment.
Yes, it was "must allow" typo. "May allow" is more correct. "Would require" has an opposite meaning
There was a problem hiding this comment.
Happy to be wrong, thanks for chiming in!
|
@theuni that's fair, thank you for the feedback, wouldn't have hurt to wait a bit. |
Merges and improves on the editorial spelling/grammar suggestions in #1720.
Closes #1720.