Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test postgres #7

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

ValuedMammal
Copy link
Collaborator

@ValuedMammal ValuedMammal commented Sep 24, 2024

@ValuedMammal ValuedMammal force-pushed the ci/job branch 2 times, most recently from 099b62e to 8198031 Compare September 24, 2024 03:01
@ValuedMammal ValuedMammal marked this pull request as ready for review September 24, 2024 03:06
@ValuedMammal
Copy link
Collaborator Author

@matthiasdebernardini Do you want to take a look at this and help decide if it would be a good direction to go?

@matthiasdebernardini
Copy link
Collaborator

Do we need to run the sqlx-cli? the app runs its own migrations and then tears it all down at the end, I think for this that's fine, what do you think?

@ValuedMammal
Copy link
Collaborator Author

ValuedMammal commented Sep 24, 2024

Oh good point.. Only that if we opt not to use sqlx-cli we have to hardcode the CREATE DATABASE statement in CI?

@matthiasdebernardini
Copy link
Collaborator

that's what the migration does no?

if self.migration {

@ValuedMammal ValuedMammal force-pushed the ci/job branch 2 times, most recently from 620d5f6 to f1ff6d0 Compare September 24, 2024 23:41
@ValuedMammal
Copy link
Collaborator Author

212aa65 replaces sqlx-cli with a psql command to create the test database in CI.

@ValuedMammal ValuedMammal merged commit 212aa65 into bitcoindevkit:master Sep 25, 2024
2 checks passed
@ValuedMammal ValuedMammal deleted the ci/job branch September 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI to github workflows
2 participants