Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): introduce FilterIter #1614

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat(rpc): introduce FilterIter #1614

merged 2 commits into from
Jan 27, 2025
+573 −1

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Sep 15, 2024 •
edited
Loading

The PR adds a bip158 module to the bdk_bitcoind_rpc crate along with a new type FilterIter that can be used for retrieving blocks from a full node which contain transactions relevant to a list of script pubkeys.

Notes to the reviewers

Changelog notice

bdk_bitcoind_rpc: Added bip158 module as a means of updating bdk_chain structures

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@evanlinjin
Copy link
Member

This is what we've all been waiting for.

@LLFourn
Copy link
Contributor

LLFourn commented Sep 30, 2024

ConceptACK. Don't have time for a full review now. @evanlinjin?

@notmandatory notmandatory added this to the 1.1.0 milestone Oct 15, 2024
@notmandatory notmandatory added the discussion There's still a discussion ongoing label Oct 15, 2024
oleonardolima
oleonardolima reviewed Oct 17, 2024
View reviewed changes
crates/bitcoind_rpc/examples/bip158.rs Outdated Show resolved Hide resolved
crates/bitcoind_rpc/examples/bip158.rs Outdated Show resolved Hide resolved
crates/bitcoind_rpc/tests/bip158.rs Outdated Show resolved Hide resolved
crates/bitcoind_rpc/src/bip158.rs Outdated Show resolved Hide resolved
@ValuedMammal
Copy link
Contributor Author

Thanks for the review @oleonardolima

@ValuedMammal
Copy link
Contributor Author

Rebased and addressed comments from @oleonardolima

@ValuedMammal ValuedMammal force-pushed the feat/filter-iter branch 2 times, most recently from 455c16c to 1074412 Compare October 23, 2024 14:22
nymius
nymius reviewed Jan 9, 2025
View reviewed changes
crates/bitcoind_rpc/tests/test_filter_iter.rs Outdated Show resolved Hide resolved
crates/bitcoind_rpc/src/bip158.rs Outdated Show resolved Hide resolved
@ValuedMammal
Copy link
Contributor Author

In the last push

  • Removed unneeded next_filter field
  • Fixed up test checking for Error::NoScripts
  • Added test filter_iter_returns_matched_blocks

CI failure seems unrelated

oleonardolima
oleonardolima reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK db65d96

@ValuedMammal ValuedMammal force-pushed the feat/filter-iter branch 2 times, most recently from 19a5926 to 7ad95d3 Compare January 18, 2025 00:02
@ValuedMammal
Copy link
Contributor Author

Rebased

nymius
nymius approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@nymius nymius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 7ad95d3

@ValuedMammal
Copy link
Contributor Author

Rebased

notmandatory
notmandatory approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a6364e2

This is cool stuff, I added some docs to make it easier for others to run.

@ValuedMammal
Copy link
Contributor Author

Thanks @notmandatory

@notmandatory notmandatory merged commit 82a2423 into bitcoindevkit:master Jan 27, 2025
23 checks passed
@ValuedMammal ValuedMammal deleted the feat/filter-iter branch January 27, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima left review comments

@nymius nymius nymius approved these changes

@notmandatory notmandatory notmandatory approved these changes

@LLFourn LLFourn Awaiting requested review from LLFourn

Assignees

@ValuedMammal ValuedMammal

Labels
discussion There's still a discussion ongoing module-blockchain new feature New feature or request
Projects
BDK
Status: Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ValuedMammal @evanlinjin @LLFourn @notmandatory @oleonardolima @nymius