Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): improve safety on finaize psbt #1790

Merged

Conversation

f3r10
Copy link
Contributor

@f3r10 f3r10 commented Jan 5, 2025

fix #1711

Description

This PR replaces how currently potentially bug-prone PSBT's input access is done using a more carefully approach.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rustaceanrob
Copy link
Contributor

ACK e8a9638

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e8a9638

@evanlinjin evanlinjin merged commit b2876d8 into bitcoindevkit:master Jan 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve safety of finalize_psbt
4 participants