Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
Julusian committed Dec 19, 2024
1 parent 2ffa9e6 commit dfdf985
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class FragmentFeedbackInstance {
*/
readonly #controlId: string

readonly #data: Omit<FeedbackInstance, 'children'>
readonly #data: Omit<FeedbackInstance, 'children' | 'advancedChildren'>

#children = new Map<FeedbackChildGroup, FragmentFeedbackList>()

Expand Down
8 changes: 4 additions & 4 deletions companion/lib/Controls/Fragments/FragmentFeedbacks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ export class FragmentFeedbacks {
* Get all the feedback instances
* @param onlyConnectionId Optionally, only for a specific connection
*/
getFlattenedFeedbackInstances(onlyConnectionId?: string): Omit<FeedbackInstance, 'children'>[] {
getFlattenedFeedbackInstances(onlyConnectionId?: string): Omit<FeedbackInstance, 'children' | 'advancedChildren'>[] {
const instances: FeedbackInstance[] = []

const extractInstances = (feedbacks: FeedbackInstance[]) => {
Expand All @@ -433,12 +433,12 @@ export class FragmentFeedbacks {
instances.push({
...feedback,
children: undefined,
advancedChildren: undefined,
})
}

if (feedback.children) {
extractInstances(feedback.children)
}
if (feedback.children) extractInstances(feedback.children)
if (feedback.advancedChildren) extractInstances(feedback.advancedChildren)
}
}

Expand Down

0 comments on commit dfdf985

Please sign in to comment.