Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: surfaces stick to a page id #3021

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Sep 7, 2024

Follow up to #2689

Surfaces now track the page id, rather than page number.
This means that when reordering pages, they won't change what page is shown and instead redraw with the new topbar numbers.
The aim here is to allow users to insert and reorder pages freely, and not end up with streamdecks scattered onto random pages

TODO:

  • Needs some more testing
  • Needs to fixup the surface settings fields for old configs

@Julusian Julusian added this to the v3.develop milestone Sep 7, 2024
@Julusian Julusian marked this pull request as ready for review September 9, 2024 18:44
@Julusian Julusian merged commit 3af86b4 into develop Sep 9, 2024
12 of 13 checks passed
@Julusian Julusian deleted the feat/reference-pages-by-id branch September 9, 2024 18:49
@Julusian Julusian modified the milestones: v3.develop, v3.5 Sep 18, 2024
@Julusian Julusian mentioned this pull request Sep 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant