Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui improvements for pages editor #3080

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

bryce-seifert
Copy link
Member

No description provided.

@krocheck
Copy link
Member

@bryce-seifert when submitting PRs, please include descriptions and screenshots (where applicable) of what the modifications are.

I'm not a fan of these changes, especially adding the text to the buttons. Although it clarifies, its a deviation from how buttons of a similar nature are placed in other contexts IMO. I do like the concept of the "Jump To" button instead of clicking the number. That's definitely a worthwhile change.

@bryce-seifert
Copy link
Member Author

Understood on images, I see how that can be helpful especially in a UI context.

I'll see if I can rework these to be more similar to other areas of Companion.

@Julusian
Copy link
Member

Yeah, the lack of labels was intentional, for consistency with elsewhere.
The navigating to the page on clicking the number I agree could be improved, I've forgotten thats a thing at times (and I forgot to change the style of it to match the other buttons)

Oh and yeah the icon being faPaperPlane, I feel like that was me picking something random while developing and forgetting to go back and change it..
For my current feature, i randomly chose faDog

@bryce-seifert
Copy link
Member Author

Thanks for the feedback, I've reverted adding the text and tried to style more inline with the other UI buttons. Let me know how we feel about this:

Screenshot 2024-10-12 at 12 04 42 PM Screenshot 2024-10-12 at 12 04 47 PM

@krocheck
Copy link
Member

@Julusian I'm good with this now.

@Julusian Julusian merged commit cbe6c31 into bitfocus:main Oct 24, 2024
4 of 5 checks passed
@bryce-seifert bryce-seifert deleted the ui/PagesEditor branch October 28, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants