ci: update rules for linter and abi generator

bitmark-inc · Feb 28, 2024 · 137c711 · 137c711
1 parent 2b87afa
commit 137c711
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/abi-gen.yaml b/.github/workflows/abi-gen.yaml
@@ -1,13 +1,12 @@
 name: Generate ABIs
 
 on:
-  pull_request:
-    branches: [ main ]
-    paths:
-      - '**/*.sol'
+  pull_request_review:
+    types: [submitted]
 
 jobs:
   gen-abi:
+    if: github.event.review.state == 'APPROVED'
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -31,7 +30,7 @@ jobs:
 
       - name: Install abigen
         run: |
-          go install github.com/ethereum/go-ethereum/cmd/abigen@1.13.14
+          go install github.com/ethereum/go-ethereum/cmd/abigen@latest
 
       - name: Write secret.json file
         env:

diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -1,6 +1,10 @@
 name: Solidity Lint
 
-on: [pull_request]
+on:
+  pull_request:
+    branches: [ main ]
+    paths:
+      - '**/*.sol'
 
 jobs:
   solidity-lint:
@@ -31,4 +35,4 @@ jobs:
       env:
         REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       run: |
-        reviewdog -f=sarif -name="solhint" -reporter=github-pr-review -filter-mode=added < solhint-report.txt
+        reviewdog -f=sarif -name="solhint" -reporter=github-pr-review -filter-mode=added < solhint-report.txt