Feature/1706 english auction #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienngovan
force-pushed
the
feature/1706-english-auction
branch
from
a01cd98 to
1f8edb0
Compare
lpopo0856
reviewed
Oct 23, 2023
tienngovan
force-pushed
the
feature/1706-english-auction
branch
3 times, most recently
from
bfa5843 to
4411b74
Compare
tienngovan
force-pushed
the
feature/1706-english-auction
branch
from
4411b74 to
d327ea8
Compare
rewrite
lpopo0856
force-pushed
the
feature/1706-english-auction
branch
from
92dc0c0 to
2f7a105
Compare
tienngovan
force-pushed
the
feature/1706-english-auction
branch
3 times, most recently
from
4be0b6c to
6e92b8c
Compare
| "FeralfileEnglishAuction: bidder is the current winner" | ||
| ); | ||
|
|
||
| if (highestBid_.amount > 0) { |
There was a problem hiding this comment.
It should be highestBid_.id > 0 for avoid the confuse.
|
|
||
| auctions[auctionID_].isSettled = true; | ||
|
|
||
| // saleData_.price = highestBid_.amount; |
There was a problem hiding this comment.
accept finalize auction with price is zero
tienngovan
force-pushed
the
feature/1706-english-auction
branch
from
6e92b8c to
255c6a2
Compare
tienngovan
force-pushed
the
feature/1706-english-auction
branch
from
255c6a2 to
837b96f
Compare
lpopo0856
force-pushed
the
feature/1706-english-auction
branch
from
7a58ff5 to
9040dff
Compare
jollyjoker992
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.