implement mergeable contract #43
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| import {FeralfileExhibitionV4_1} from "./FeralfileArtworkV4_1.sol"; | ||
|
|
||
| contract FeralfileExhibitionV4_3 is FeralfileExhibitionV4_1 { |
There was a problem hiding this comment.
Contract, Structs and Enums should be in CamelCase
| } | ||
| MergeArtworkInfo private mergeArtworkInfo; | ||
|
|
||
| constructor( |
There was a problem hiding this comment.
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
| revert("FeralfileExhibitionV4: duplicate seriesId"); | ||
| } | ||
| } | ||
| require( |
There was a problem hiding this comment.
Error message for require is too long: 41 counted / 32 allowed
| revert("FeralfileExhibitionV4: duplicate seriesId"); | ||
| } | ||
| } | ||
| require( |
There was a problem hiding this comment.
GC: String exceeds 32 bytes
| revert("FeralfileExhibitionV4: duplicate seriesId"); | ||
| } | ||
| } | ||
| require( |
There was a problem hiding this comment.
GC: Use Custom Errors instead of require statements
hvthhien
force-pushed
the
mergeable_contract
branch
2 times, most recently
from
e71a5d9 to
f2fcc66
Compare
hvthhien
force-pushed
the
mergeable_contract
branch
from
3e79b75 to
9e86016
Compare
hvthhien
force-pushed
the
mergeable_contract
branch
from
fd807e0 to
5819d7f
Compare
hvthhien
force-pushed
the
mergeable_contract
branch
from
2e8aacb to
907370f
Compare
hvthhien
force-pushed
the
mergeable_contract
branch
from
2c05f72 to
cf88d4b
Compare
hvthhien
force-pushed
the
mergeable_contract
branch
from
20b5606 to
d0753a6
Compare
hvthhien
force-pushed
the
mergeable_contract
branch
from
bcc4826 to
628aaf5
Compare
|
|
||
| import {FeralfileExhibitionV4_1} from "./FeralfileArtworkV4_1.sol"; | ||
|
|
||
| contract FeralfileExhibitionV4_3 is FeralfileExhibitionV4_1 { |
There was a problem hiding this comment.
Contract, Structs and Enums should be in CamelCase
| // merging | ||
| bool internal _merging; | ||
|
|
||
| constructor( |
There was a problem hiding this comment.
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
| revert("FeralfileExhibitionV4: duplicate seriesId"); | ||
| } | ||
| } | ||
| require( |
There was a problem hiding this comment.
Error message for require is too long: 41 counted / 32 allowed
| revert("FeralfileExhibitionV4: duplicate seriesId"); | ||
| } | ||
| } | ||
| require( |
There was a problem hiding this comment.
GC: String exceeds 32 bytes
| revert("FeralfileExhibitionV4: duplicate seriesId"); | ||
| } | ||
| } | ||
| require( |
There was a problem hiding this comment.
GC: Use Custom Errors instead of require statements
hvthhien
force-pushed
the
mergeable_contract
branch
from
9f2ea3d to
d11196f
Compare
| } | ||
| MergeArtworkInfo private mergeArtworkInfo; | ||
|
|
||
| constructor( |
There was a problem hiding this comment.
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
hvthhien
force-pushed
the
mergeable_contract
branch
from
f49a870 to
c4ed18e
Compare
https://github.com/bitmark-inc/feral-file/issues/2567