Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13626] Remember last opened view for 5 minutes #4574
base: main
Are you sure you want to change the base?
[PM-13626] Remember last opened view for 5 minutes #4574
Changes from 17 commits
8007888
876df9a
0d1565a
885e4b5
7937c22
cf91608
fa0cdd9
c934288
b374725
286ecd5
54826d6
f98e93c
bbbd31f
2bd72a4
7438b48
565659f
126fabf
422bb7f
5c27d51
edf4f91
fa94b47
309a249
459ea5e
b3ff6a0
6b559c8
b9c6574
55bc827
5b7bcd0
3548304
c9a7ec6
ca5dbaf
2f50cea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should not be needed. Or you could you make it a javadoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โ๏ธ I appreciate the comment here, but the
_MS
immediately makes me thinkmilliseconds
,UNLOCK_NAVIGATION_TIME_MINUTES
can never go wrong being UBER explicit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is my bad, I told him to add
_MS
because I thought it was milliseconds.It should be
UNLOCK_NAVIGATION_TIME_SECONDS
since the value is in secondsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ")" is on the bottom line, formatter will format it like above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
?:
should be on its own line for proper chaining.This would also be fine:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐