Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13351] Prevent editing of TOTP key in 'can edit except passwords' collection #4583

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Jan 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13351

📔 Objective

This disables the ability to edit the TOTP key if the item is part of a collection with Can Edit, Except Passwords permission

📸 Screenshots

Item with existing TOTP key:

android_can-edit-except-pw-item-with-totp

Item without existing TOTP key:

android_can-edit-except-pw-item-without-totp

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Logo
Checkmarx One – Scan Summary & Details31826f15-257c-4c00-9194-b36f2126e5ea

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (be40149) to head (d229464).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4583      +/-   ##
==========================================
- Coverage   88.36%   88.34%   -0.03%     
==========================================
  Files         603      603              
  Lines       40720    40744      +24     
  Branches     5720     5721       +1     
==========================================
+ Hits        35983    35996      +13     
- Misses       2747     2757      +10     
- Partials     1990     1991       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-livefront
Copy link
Collaborator

The code looks good to me, do we have any tests for this?

@mpbw2
Copy link
Contributor Author

mpbw2 commented Jan 17, 2025

The code looks good to me, do we have any tests for this?

Still working on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants