PM-16622 PM-16623 and PM-16624 Add the first three coach marks to the generator tour #4613
Conversation
dseverns-livefront
requested review from
brian-livefront,
david-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
…he segemented controls along with how the nav bar scrim shows more
dseverns-livefront
force-pushed
the
PM-16622-generator-coachmarks
branch
from
43bd1bc to
a04f1ac
Compare
|
Great job, no security vulnerabilities found in this Pull Request |
| "password_option" -> { | ||
| CoachMarkHighlight( | ||
| key = ExploreGeneratorCoachMark.PASSWORD_MODE, | ||
| title = stringResource(R.string.coachmark_1_of_6), |
There was a problem hiding this comment.
It is probably still to long but can we open this up a bit:
description = stringResource(
id = R.string.use_the_generator_to_create_secure_passwords_passphrases_and_usernames,
),There was a problem hiding this comment.
yeah, we will still need the suppression but can def do this!
| CoachMarkHighlight( | ||
| key = ExploreGeneratorCoachMark.PASSPHRASE_MODE, | ||
| title = stringResource(R.string.coachmark_2_of_6), | ||
| description = stringResource(R.string.passphrases_are_strong_passwords_that_are_often_easier_to_remember_and_type_than_random_passwords), |
| CoachMarkHighlight( | ||
| key = ExploreGeneratorCoachMark.USERNAME_MODE, | ||
| title = stringResource(R.string.coachmark_3_of_6), | ||
| description = stringResource(R.string.unique_usernames_add_an_extra_layer_of_security_and_can_help_prevent_hackers_from_finding_your_accounts), |
| @@ -443,7 +513,79 @@ private fun MainStateOptionsItem( | |||
| modifier = modifier | |||
| .fillMaxWidth() | |||
| .testTag(tag = "GeneratorTypePicker"), | |||
| ) | |||
| ) { option -> | |||
| when (option.testTag) { | |||
There was a problem hiding this comment.
Could we do this by index or something. We should not rely on test tags for this.
| @@ -101,6 +116,8 @@ fun GeneratorScreen( | |||
| viewModel: GeneratorViewModel = hiltViewModel(), | |||
| onNavigateToPasswordHistory: () -> Unit, | |||
| onNavigateBack: () -> Unit, | |||
| onDimNavBarRequest: (Boolean) -> Unit, | |||
| scrimClickCount: State<Int>, | |||
There was a problem hiding this comment.
Can you tell me a little more about this scrimClickCount?
There was a problem hiding this comment.
Within the CoachMarkContainer we handle any clicks outside the tooltips and then essential re-show the tooltip for the current coachmark (default behaviour dismissed this via google locking it down). Since the bottom bar is outside the container we need to capture if the user clicks in that space otherwise it will dismiss the tool tip, I am using this value in the launched effect to call the function if this state updates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4613 +/- ##
=======================================
Coverage 88.35% 88.36%
=======================================
Files 603 604 +1
Lines 40746 40838 +92
Branches 5738 5744 +6
=======================================
+ Hits 36003 36085 +82
- Misses 2742 2750 +8
- Partials 2001 2003 +2 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
PM-16622
PM-16623
PM-16624
📔 Objective
📸 Screenshots
16622.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes