Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17485] [PM-16961] Fix opening vault item URLs with no scheme #4615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elidrissidev
Copy link

🎟️ Tracking

#4552

📔 Objective

This PR fixes an issue where vault item URLs entered without a scheme and not starting with // (e.g. github.com) may not open properly on some browsers. Technically this is not a bug but is due to the way URIs are parsed per the RFC, which treats the above example as a path instead of a host name. So the URL that's actually sent in the intent becomes https:/github.com.

The proposed solution should work well with all the different ways of typing a URL: https://github.com, //github.com, and github.com.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-17485

@bitwarden-bot bitwarden-bot changed the title [PM-16961] Fix opening vault item URLs with no scheme [PM-17485] [PM-16961] Fix opening vault item URLs with no scheme Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants