Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-16630 PM-16621 Add logins action card and add explore generator card to be able to trigger coach marks #4616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Jan 23, 2025

๐ŸŽŸ๏ธ Tracking

PM-16621
PM-16630

๐Ÿ“” Objective

  • Show action cards if they have not been shown to user before and the native onboarding feature flag is enabled.
  • Once interacting with the card, should be removed from screens and not show again.

๐Ÿ“ธ Screenshots

16630and16621.mp4

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

PM-16621 add explore generator card to be able to trigger coach marks
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ b0d03689-b8d2-49a2-a360-5fd12cda2c18

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 88.40%. Comparing base (d573ce6) to head (05dd272).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   88.35%   88.40%   +0.04%     
==========================================
  Files         603      603              
  Lines       40746    40882     +136     
  Branches     5738     5755      +17     
==========================================
+ Hits        36003    36140     +137     
  Misses       2742     2742              
+ Partials     2001     2000       -1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant