Dapps modals #2490
Dapps modals #2490
Conversation
|
Hi @varunguleriaCodes All we need to change in this task is to open /apps page (with a given dapp modal opened) instead of dapp link (only for external dapps). |
|
Hi @isstuev , got it working on suggested changes |
|
Hi @isstuev implemented the suggested changes. |
ui/marketplace/useMarketplace.tsx
Outdated
| if (selectedAppId) { | ||
| setSelectedAppId(selectedAppId); | ||
| setIsAppInfoModalOpen(true); | ||
| const newQuery = { ...router.query }; |
There was a problem hiding this comment.
please use frontend/lib/router/removeQueryParam.ts
| @@ -1,5 +1,6 @@ | |||
| import { Image, Flex, Text, useColorModeValue } from '@chakra-ui/react'; | |||
There was a problem hiding this comment.
We also have Search Results page where apps can also be displayed, I suppose we need to implement the same logic there
frontend/ui/searchResults/SearchResultTableItem.tsx
frontend/ui/searchResults/SearchResultListItem.tsx
|
Hi @isstuev , I have added the changes, also changed useEffect in rating components, as when I was redirecting in a new tab to /apps this error showed "maximum update depth error reached" |
|
@varunguleriaCodes Our tests are failing because the SearchBar component now relies on the router implementation. Can you pass the router mock here, similar to other instances (example)? That should fix the tests. |
|
Hi @tom2drum ,Done |
Description and Related Issue(s)
This is a pr for #2454
Proposed Changes
Added a popup for an external dapp as specified in #2454
Additional Information
[Include any additional information, context, or screenshots that may be helpful for reviewers.]
Pc View
Mobile View
Checklist for PR author