Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash with es-toolkit #2503

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Replace lodash with es-toolkit #2503

wants to merge 7 commits into from

Conversation

tom2drum
Copy link
Collaborator

@tom2drum tom2drum commented Jan 6, 2025

Description and Related Issue(s)

Resolves #2092

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@tom2drum tom2drum added the dependencies Pull requests that update a dependency file label Jan 6, 2025
tom2drum
tom2drum commented Jan 6, 2025
View reviewed changes
ui/snippets/searchBar/__screenshots__/SearchBar.pw.tsx_default_scroll-suggest-to-category-1.png
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sreenshot was updated to reflect current app behavior.

Screen.Recording.2025-01-06.at.11.56.22.AM.mov

@tom2drum tom2drum requested a review from isstuev January 6, 2025 11:00
@github-actions github-actions bot added the tech Issues related to building, testing, and other project tooling label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isstuev isstuev Awaiting requested review from isstuev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file tech Issues related to building, testing, and other project tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace lodash with es-toolkit
1 participant
@tom2drum