-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bugreport command #28
Conversation
Shouldn't the bug report ask for recipe.yml or GitHub repo link (if related)? This would probably be used to report all kinds of potentially unrelated bugs that just surface when using the tool. Logs for bugged run of the tool could be needed too. |
Yeah I'm going to be fixing it up today. @xynydev do you want to draft a template for prs to use? You are better with words than I am |
Thanks! Do you mean PRs or issues? I don't see how a PR template is related to this. |
5496505
to
e2bab54
Compare
Ready for review :) |
Looks like there's a problem with the build, I'll take a look after work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there's a lot here I'm commenting on. You've done a ton of amazing work here! I also think this PR has highlighted to me that we both have slightly different tastes in how we structure code, which is perfectly fine. I think we should open up a discussion post to solidify some structure guidelines with input from the members.
Keep up the great work, man!
Generated IssueCurrent BehaviorExpected BehaviorAdditional context/ScreenshotsPossible SolutionEnvironment
Shell
This is free software; you are free to change and redistribute it.
Rust
Recipe:- type: files
files:
- homedir: /usr/etc/homedir
- usr: /usr
- type: files
files:
- usr: /usr
- type: rpm-ostree
repos:
- https://copr.fedorainfracloud.org/coprs/agriffis/neovim-nightly
- https://copr.fedorainfracloud.org/coprs/atim/starship/repo/fedora-%OS_VERSION%/atim-starship-fedora-%OS_VERSION%.repo
install:
- neovim
- starship
remove:
- firefox
- firefox-langpacks
- type: default-flatpaks
notify: true
system:
repo-url: https://dl.flathub.org/repo/flathub.flatpakrepo
repo-name: flathub
install: null
remove: null
user:
repo-url: https://dl.flathub.org/repo/flathub.flatpakrepo
repo-name: flathub
- type: script
scripts:
- signing.sh |
Why're the top-level keys left out of the included recipe entirely? Can't they cause errors too? |
That should be fixed with my changes I pushed last night |
Ok, with these changes my bug report ends up being this: Current BehaviorExpected BehaviorAdditional context/ScreenshotsPossible SolutionEnvironment
Shell
This is free software; you are free to change and redistribute it.
Rust
Recipe:name: jp-desktop
description: The image of Wunker OS for JP's desktop.
base_image: ghcr.io/ublue-os/kinoite-nvidia
image_version: '39'
blue_build_tag: null
modules:
- type: files
files:
- 8bitdo-ultimate: /usr
- steam-firewall: /usr
- desktop-audio: /usr
- type: containerfile
containerfiles:
- xboxdrv
- type: files
files:
- usr: /usr
- distrobox: /usr
- type: script
scripts:
- install-mkcert.sh
- install-syncthing.sh
- setup-kubectl.sh
- type: rpm-ostree
repos:
- https://pkg.earthly.dev/earthly.repo
- https://copr.fedorainfracloud.org/coprs/varlad/helix/repo/fedora-%OS_VERSION%/varlad-helix-fedora-%OS_VERSION%.repo
- https://pkgs.tailscale.com/stable/fedora/%OS_VERSION%/tailscale.repo
- https://cli.github.com/packages/rpm/gh-cli.repo
install:
- libadwaita
- cmake
- cronie
- neofetch
- virt-manager
- plasma-browser-integration
- gcc-c++
- id3v2
- docker
- xinput
- earthly
- kubectl
- helm
- neovim
- ripgrep
- helix
- tailscale
- strawberry
- openssl1.1
- parallel
- gcc-aarch64-linux-gnu
- gcc-c++-aarch64-linux-gnu
- musl-gcc
- xclip
- alacritty
- openssl-devel
- bat
- gh
remove:
- firefox
- firefox-langpacks
- type: script
scripts:
- setup-selinux-dockersock.sh
- install-codelldb.sh |
Add a bug report + completions command so that new users can easily submit bugs to us, and I wanted completions for bb (super easy with clap)