Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bugreport command #28

Merged
merged 24 commits into from
Jan 31, 2024
Merged

feat: Bugreport command #28

merged 24 commits into from
Jan 31, 2024

Conversation

bayou-brogrammer
Copy link
Collaborator

@bayou-brogrammer bayou-brogrammer commented Jan 28, 2024

Add a bug report + completions command so that new users can easily submit bugs to us, and I wanted completions for bb (super easy with clap)

@xynydev
Copy link
Member

xynydev commented Jan 28, 2024

Shouldn't the bug report ask for recipe.yml or GitHub repo link (if related)? This would probably be used to report all kinds of potentially unrelated bugs that just surface when using the tool. Logs for bugged run of the tool could be needed too.

@bayou-brogrammer
Copy link
Collaborator Author

Yeah I'm going to be fixing it up today.

@xynydev do you want to draft a template for prs to use? You are better with words than I am

@xynydev
Copy link
Member

xynydev commented Jan 28, 2024

do you want to draft a template for prs to use? You are better with words than I am.

Thanks! Do you mean PRs or issues? I don't see how a PR template is related to this.

Cargo.toml Outdated Show resolved Hide resolved
src/bin/bb.rs Outdated Show resolved Hide resolved
src/bin/bb.rs Outdated Show resolved Hide resolved
src/bin/bb.rs Outdated Show resolved Hide resolved
src/bin/bb.rs Outdated Show resolved Hide resolved
@gmpinder gmpinder changed the title Bugreport command feat: Bugreport command Jan 28, 2024
src/commands/bug_report.rs Outdated Show resolved Hide resolved
src/commands/bug_report.rs Outdated Show resolved Hide resolved
@gmpinder gmpinder marked this pull request as draft January 29, 2024 16:28
@bayou-brogrammer bayou-brogrammer marked this pull request as ready for review January 29, 2024 17:42
@bayou-brogrammer
Copy link
Collaborator Author

Ready for review :)

@gmpinder
Copy link
Member

Looks like there's a problem with the build, I'll take a look after work

Copy link
Member

@gmpinder gmpinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there's a lot here I'm commenting on. You've done a ton of amazing work here! I also think this PR has highlighted to me that we both have slightly different tastes in how we structure code, which is perfectly fine. I think we should open up a discussion post to solidify some structure guidelines with input from the members.

Keep up the great work, man!

rust-toolchain.toml Outdated Show resolved Hide resolved
src/commands/completions.rs Outdated Show resolved Hide resolved
src/commands/template.rs Outdated Show resolved Hide resolved
src/commands/bug_report.rs Outdated Show resolved Hide resolved
src/commands/utils.rs Outdated Show resolved Hide resolved
src/module_recipe.rs Outdated Show resolved Hide resolved
src/module_recipe.rs Outdated Show resolved Hide resolved
src/module_recipe.rs Outdated Show resolved Hide resolved
templates/recipe.j2 Outdated Show resolved Hide resolved
@bayou-brogrammer
Copy link
Collaborator Author

634419

Generated Issue

Current Behavior

Expected Behavior

Additional context/Screenshots

Possible Solution

Environment

  • Blue Build Version: 0.5.5
  • Operating system: Fedora 39.0.0
  • Branch/Tag: bugreport-command (v0.5.5)
  • Git Commit Hash: 0583dcd

Shell

  • Name: bash
  • Version: GNU bash, version 5.2.15(1)-release (x86_64-pc-linux-gnu)
    Copyright (C) 2022 Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

  • Terminal emulator:

Rust

  • Rust Version: rustc 1.75.0 (82e1608df 2023-12-21)
  • Rust channel: stable-x86_64-unknown-linux-gnu debug
  • Build Time: 1980-01-01 00:00:00 +00:00

Recipe:

- type: files
  files:
  - homedir: /usr/etc/homedir
  - usr: /usr

- type: files
  files:
  - usr: /usr

- type: rpm-ostree
  repos:
  - https://copr.fedorainfracloud.org/coprs/agriffis/neovim-nightly
  - https://copr.fedorainfracloud.org/coprs/atim/starship/repo/fedora-%OS_VERSION%/atim-starship-fedora-%OS_VERSION%.repo
  install:
  - neovim
  - starship
  remove:
  - firefox
  - firefox-langpacks

- type: default-flatpaks
  notify: true
  system:
    repo-url: https://dl.flathub.org/repo/flathub.flatpakrepo
    repo-name: flathub
    install: null
    remove: null
  user:
    repo-url: https://dl.flathub.org/repo/flathub.flatpakrepo
    repo-name: flathub

- type: script
  scripts:
  - signing.sh

@xynydev
Copy link
Member

xynydev commented Jan 30, 2024

Why're the top-level keys left out of the included recipe entirely? Can't they cause errors too?

@gmpinder
Copy link
Member

Why're the top-level keys left out of the included recipe entirely? Can't they cause errors too?

That should be fixed with my changes I pushed last night

@bayou-brogrammer bayou-brogrammer enabled auto-merge (squash) January 30, 2024 13:50
@gmpinder
Copy link
Member

gmpinder commented Jan 30, 2024

Ok, with these changes my bug report ends up being this:


Current Behavior

Expected Behavior

Additional context/Screenshots

Possible Solution

Environment

  • Blue Build Version: 0.5.5
  • Operating system: Fedora 39.0.0
  • Branch/Tag: bugreport-command (v0.5.5)
  • Git Commit Hash: 0583dcd

Shell

  • Name: bash
  • Version: GNU bash, version 5.2.26(1)-release (x86_64-redhat-linux-gnu)
    Copyright (C) 2022 Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

  • Terminal emulator: tmux next-3.4

Rust

  • Rust Version: rustc 1.75.0 (82e1608df 2023-12-21)
  • Rust channel: stable-x86_64-unknown-linux-gnu release
  • Build Time: 2024-01-29 22:57:26 -05:00

Recipe:

name: jp-desktop
description: The image of Wunker OS for JP's desktop.
base_image: ghcr.io/ublue-os/kinoite-nvidia
image_version: '39'
blue_build_tag: null
modules:
- type: files
  files:
  - 8bitdo-ultimate: /usr
  - steam-firewall: /usr
  - desktop-audio: /usr
- type: containerfile
  containerfiles:
  - xboxdrv
- type: files
  files:
  - usr: /usr
  - distrobox: /usr
- type: script
  scripts:
  - install-mkcert.sh
  - install-syncthing.sh
  - setup-kubectl.sh
- type: rpm-ostree
  repos:
  - https://pkg.earthly.dev/earthly.repo
  - https://copr.fedorainfracloud.org/coprs/varlad/helix/repo/fedora-%OS_VERSION%/varlad-helix-fedora-%OS_VERSION%.repo
  - https://pkgs.tailscale.com/stable/fedora/%OS_VERSION%/tailscale.repo
  - https://cli.github.com/packages/rpm/gh-cli.repo
  install:
  - libadwaita
  - cmake
  - cronie
  - neofetch
  - virt-manager
  - plasma-browser-integration
  - gcc-c++
  - id3v2
  - docker
  - xinput
  - earthly
  - kubectl
  - helm
  - neovim
  - ripgrep
  - helix
  - tailscale
  - strawberry
  - openssl1.1
  - parallel
  - gcc-aarch64-linux-gnu
  - gcc-c++-aarch64-linux-gnu
  - musl-gcc
  - xclip
  - alacritty
  - openssl-devel
  - bat
  - gh
  remove:
  - firefox
  - firefox-langpacks
- type: script
  scripts:
  - setup-selinux-dockersock.sh
  - install-codelldb.sh

gmpinder
gmpinder previously approved these changes Jan 30, 2024
@bayou-brogrammer bayou-brogrammer merged commit e069346 into main Jan 31, 2024
1 check passed
@bayou-brogrammer bayou-brogrammer deleted the bugreport-command branch January 31, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants